Add support for decoding fog parameters to the FileFormats library #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are required in order to decode the fog parameters table.
Much easier to debug if it doesn't just display the default "cdata" representation.
The code is ancient; it was part of the now-archived RagnarokTools repository. I didn't change too much about it so it's still questionable, but I suppose that's really not a problem here. Only minor adjustments were made to make use of the Color metatype and to make the code more testable.
Extremely unlikely to change, so this minimal test case should suffice.
rdw-software
force-pushed
the
132-decode-fog-parameters
branch
from
8dcd5ea
to
3486b9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of the vertex fog feature; since the data is readily available in the GRF archive, might as well use it directly.