Enable taking screenshots via SPACE key #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now it's hardcoded to SPACE, though later it should be made configurable.
This allows switching render targets on the fly, without the need for additional color attachments (which would increase VRAM usage).
I have no plans to add more advanced rendering features that would require modifying the depth or stencil attachment, but a more generalized approach to managing render targets should nevertheless help with separating the different rendering modes.
The idea is to swap this in on-the-fly to capture the frame buffer contents, without having to modify anything but the selected rendering pipeline for each material.
For now they're blocking, since the time taken isn't that long. It does skip a few frames, but offloading the encoding step would be more complex than just doing it on the main thread and eating the dropped frames. It can also timeout the surface texture and crash the renderer, but that's a separate problem and will be tackled soon (TM).
rdw-software
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #336.