Merge pull request #396 from RailsEventStore/fix-time-promotion-bug

Fix time promotions bug

ecommerce/pricing/lib/pricing/promotions_calendar.rb

@@ -45,9 +45,8 @@ def initialize(start_time, end_time, discount)
       end
 
       def running?(timestamp)
-        (@start_time...@end_time).include?(timestamp)
+        (@start_time...@end_time).cover?(timestamp)
       end
-
     end
   end
 end

rails_application/test/integration/client_orders_test.rb

@@ -187,6 +187,21 @@ def test_shows_out_of_stock_badge
     assert_select "td span", "out of stock"
   end
 
+  def test_current_time_promotion_is_applied
+    customer_id = register_customer("Customer Shop")
+    product_id = register_product("Fearless Refactoring", 4, 10)
+    create_current_time_promotion
+
+    login(customer_id)
+    visit_client_orders
+
+    order_id = SecureRandom.uuid
+    as_client_add_item_to_basket_for_order(product_id, order_id)
+    as_client_submit_order_for_customer(order_id)
+
+    assert_select "tr td", "$2.00"
+  end
+
   private
 
   def submit_order_for_customer(customer_id, order_id)
@@ -248,4 +263,13 @@ def update_price(product_id, new_price)
   def login_as(client_id)
     open_session { |sess| sess.post "/login", params: { client_id: client_id } }
   end
+
+  def create_current_time_promotion(discount: 50, start_time: Time.current - 1.day, end_time: Time.current + 1.day)
+    post "/time_promotions", params: {
+      label: "Last Minute",
+      discount: discount,
+      start_time: start_time,
+      end_time: end_time
+    }
+  end
 end

rails_application/test/integration/orders_test.rb

@@ -246,6 +246,27 @@ def test_shows_out_of_stock_badge
     assert_select "td span", "0"
   end
 
+  def test_current_time_promotion_is_applied
+    order_id = SecureRandom.uuid
+    async_remote_id = register_product("Async Remote", 39, 10)
+    shopify_id = register_customer("Shopify")
+
+    create_current_time_promotion
+    post "/orders/#{order_id}/add_item?product_id=#{async_remote_id}"
+
+    post "/orders",
+         params: {
+           "authenticity_token" => "[FILTERED]",
+           "order_id" => order_id,
+           "customer_id" => shopify_id,
+           "commit" => "Submit order"
+         }
+    follow_redirect!
+
+    assert_select("td", "$19.50")
+    assert_select("dd", "Submitted")
+  end
+
   private
 
   def assert_remove_buttons_visible(async_remote_id, fearless_id, order_id)
@@ -356,4 +377,13 @@ def apply_discount_10_percent(order_id)
 
     post "/orders/#{order_id}/update_discount?amount=10"
   end
+
+  def create_current_time_promotion(discount: 50, start_time: Time.current - 1.day, end_time: Time.current + 1.day)
+    post "/time_promotions", params: {
+      label: "Last Minute",
+      discount: discount,
+      start_time: start_time,
+      end_time: end_time
+    }
+  end
 end