introduce state vo #367
Merged
introduce state vo #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lukaszreszke
commented
Aug 6, 2024
lukaszreszke
commented
- Encapsulate state
- Refactor
- Allowed transitions
- Remove empty line
- add eql? and hash methods
- refactor
❌ Deploy Preview for ecommerce-events failed.
|
The `transition_to` method was only called in the `on` DSL. The problem is that the transition_to method raises the exception when state is either not allowed or it is not valid transition. Exceptions shouldn't be raised when building state of the aggregate. Past is past.
Accepted didn't get it's own method as it doesn't seem like this "accepted" information is used in any way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.