Change VAT Rate code from integer to string #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for ecommerce-events failed.
|
marlena-b
force-pushed
the
change-vat-code-to-string
branch
from
5ece0d1
to
00e9f45
Compare
|
Looks good to me, possible next step could be to make it a value object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #391
I updated the product creation code to accept the VAT rate
codeas a string, aligning it with how VAT rates are created. Additionally, I renamed the attribute in the product form tovat_rate_codeto better reflect that it represents the VAT rate code, not the entire VAT rate.