Change Result pattern to exceptions #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for ecommerce-events failed.
|
andrzejkrzywda
requested changes
Sep 12, 2024
| if unavailable_products.any? | ||
| raise OrderHasUnavailableProducts.new(unavailable_products) | ||
| end | ||
| true |
There was a problem hiding this comment.
Service objects ideally should have "void" type, we shouldn't rely on the return value - it either raises exception or its success.
| result = Orders::SubmitService.new(order_id: order_id, customer_id: customer_id).call | ||
|
|
||
| assert_equal result.status, :success | ||
| assert_equal true, Orders::SubmitService.new(order_id: order_id, customer_id: customer_id).call |
There was a problem hiding this comment.
Let's try to test some actual effect of running this service object (read model value?) instead of testing it's return value
There was a problem hiding this comment.
Done, thank you for your comments! :)
andrzejkrzywda
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #393
I refactored the code to use exceptions instead of the Result pattern for consistency with our existing codebase.
I also renamed
order_side_effectstoupdate_order_statefor better clarity.