Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Circle Equation Calculator #1973

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Conversation

R2-STAR
Copy link
Contributor

@R2-STAR R2-STAR commented Jan 5, 2025

Fixes Issue🛠️

Closes #1946

Description👨‍💻

Added a Circle Equation Solving Calculator.

Type of Change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

Screenshot 2025-01-05 151910

Screenshot 2025-01-05 151854

Copy link

netlify bot commented Jan 5, 2025

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 6e1fc56
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/677ca581a74a2300081e44a6
😎 Deploy Preview https://deploy-preview-1973--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @R2-STAR, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Rakesh9100
Copy link
Owner

Please add a README.md file of your calculator in your folder, make the commits in this same PR.
Also, mention the formula in the web page to let users know about it @R2-STAR

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jan 5, 2025
@R2-STAR
Copy link
Contributor Author

R2-STAR commented Jan 5, 2025

@Rakesh9100 Kindly review the changes.

@Rakesh9100
Copy link
Owner

The 2nd point which I mentioned, it's not done I see in your new commit @R2-STAR

@R2-STAR
Copy link
Contributor Author

R2-STAR commented Jan 5, 2025

@Rakesh9100 Yeah i wanted to know where exactly on the web page am I supposed to mention the formula. Shall I mention this in the README file?

@Rakesh9100
Copy link
Owner

You can mention in the README as well as below the heading in the web page properly @R2-STAR

@R2-STAR
Copy link
Contributor Author

R2-STAR commented Jan 5, 2025

Apologies, but I'm having difficulty understanding. Could you kindly provide an example or a screenshot to clarify where exactly on the webpage the formula should be visible?

@Rakesh9100
Copy link
Owner

Include below the heading and before first input box here @R2-STAR

image

@R2-STAR
Copy link
Contributor Author

R2-STAR commented Jan 6, 2025

@Rakesh9100 Kindly review the changes

@Rakesh9100 Rakesh9100 merged commit 2fabca5 into Rakesh9100:main Jan 7, 2025
4 checks passed
Copy link

github-actions bot commented Jan 7, 2025

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @R2-STAR

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion SWOC SWOC Open Source Program Hard Complex or challenging task and removed question 🤔 Further information is requested labels Jan 7, 2025
@Rakesh9100 Rakesh9100 changed the title Added Circle Equation Solving Calculator Added Circle Equation Calculator Jan 7, 2025
@Bishal-35
Copy link

@Rakesh9100 I was assigned for the issue but you have merged someone else

@Rakesh9100
Copy link
Owner

He had only opened this issue and was assigned before but was not able to reply due to some issues maybe, but I forgot that I did assign you, please take up another issue, sorry for the confusion @Bishal-35

@Rakesh9100 Rakesh9100 added Advance Complex task and removed Hard Complex or challenging task labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Advance Complex task Completed 🥳 PR successfully merged and issue resolved on completion SWOC SWOC Open Source Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Circle Equation Calculator
3 participants