Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommandBuffer insert/remove ordering is a footgun #308

Open
Ralith opened this issue Mar 26, 2023 · 0 comments
Open

CommandBuffer insert/remove ordering is a footgun #308

Ralith opened this issue Mar 26, 2023 · 0 comments

Comments

@Ralith
Copy link
Owner

Ralith commented Mar 26, 2023

CommandBuffer allows deferred execution of component insertion and removal. At present, it executes all insertions first, then all removals. This might not reflect the user's intention after calling e.g. cmd.remove_one::<T>(); cmd.insert_one::<T>(x);, which could easily happen if one command buffer is reused across widely separated code, a pattern which is normally desirable to improve resource reuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant