Skip to content

Commit

Permalink
Add missing pvc namespace to the vrg rdspec
Browse files Browse the repository at this point in the history
It seems that recent change for supporting multiple namespaces have
broken failover with volsync when using multiple volsync apps. Add the
pvc namespace to the protected pvc, similar to volrep code.

I did not modify the test to validate this change since I don't fully
understand the test. It seems that there is a missing `It` section for
testing the vrg.

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
  • Loading branch information
nirs authored and BenamarMk committed Nov 29, 2023
1 parent 2271f38 commit 5cdc7eb
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions controllers/vrg_volsync.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ func (v *VRGInstance) reconcileVolSyncAsPrimary(finalSyncPrepared *bool) (requeu
func (v *VRGInstance) reconcilePVCAsVolSyncPrimary(pvc corev1.PersistentVolumeClaim) (requeue bool) {
newProtectedPVC := &ramendrv1alpha1.ProtectedPVC{
Name: pvc.Name,
Namespace: pvc.Namespace,
ProtectedByVolSync: true,
StorageClassName: pvc.Spec.StorageClassName,
Annotations: protectedPVCAnnotations(pvc),
Expand Down

0 comments on commit 5cdc7eb

Please sign in to comment.