Skip to content

Commit

Permalink
cleanup even for volsync
Browse files Browse the repository at this point in the history
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
  • Loading branch information
raghavendra-talur committed Sep 10, 2024
1 parent ba54b00 commit 68b54be
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions internal/controller/drplacementcontrol.go
Original file line number Diff line number Diff line change
Expand Up @@ -1732,16 +1732,16 @@ func (d *DRPCInstance) EnsureCleanup(clusterToSkip string) error {
d.log.Info(fmt.Sprintf("PeerReady Condition is %s, msg: %s", condition.Status, condition.Message))

// IFF we have VolSync PVCs, then no need to clean up
homeCluster := clusterToSkip
// homeCluster := clusterToSkip

repReq, err := d.IsVolSyncReplicationRequired(homeCluster)
if err != nil {
return fmt.Errorf("failed to check if VolSync replication is required (%w)", err)
}
//repReq, err := d.IsVolSyncReplicationRequired(homeCluster)

Check failure on line 1737 in internal/controller/drplacementcontrol.go

View workflow job for this annotation

GitHub Actions / Golangci Lint (.)

commentFormatting: put a space between `//` and comment text (gocritic)
//if err != nil {
// return fmt.Errorf("failed to check if VolSync replication is required (%w)", err)
//}

if repReq {
return d.cleanupForVolSync(clusterToSkip)
}
//if repReq {

Check failure on line 1742 in internal/controller/drplacementcontrol.go

View workflow job for this annotation

GitHub Actions / Golangci Lint (.)

commentFormatting: put a space between `//` and comment text (gocritic)
// return d.cleanupForVolSync(clusterToSkip)
//}

clean, err := d.cleanupSecondaries(clusterToSkip)
if err != nil {
Expand Down

0 comments on commit 68b54be

Please sign in to comment.