Enable bool-literal-in-expr revive flag

Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
RamenDR · Dec 13, 2023 · bc6dd0c · bc6dd0c
1 parent 6559c0b
commit bc6dd0c
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -77,7 +77,7 @@ linters-settings:
       # - name: confusing-naming
       # - name: import-shadowing
       - name: confusing-results
-      # - name: bool-literal-in-expr
+      - name: bool-literal-in-expr
 
 issues:
   exclude-rules:

diff --git a/controllers/drcluster_mmode_test.go b/controllers/drcluster_mmode_test.go
@@ -62,7 +62,7 @@ var _ = Describe("DRClusterMModeTests", Ordered, func() {
 			},
 		}
 
-		if testEnv.UseExistingCluster != nil && *testEnv.UseExistingCluster == true {
+		if testEnv.UseExistingCluster != nil && *testEnv.UseExistingCluster {
 			namespaceDeletionSupported = true
 		}
 

diff --git a/controllers/drpc_predicate_test.go b/controllers/drpc_predicate_test.go
@@ -239,7 +239,7 @@ var _ = Describe("DRPCPredicateDRCluster", func() {
 				},
 			}
 
-			if testEnv.UseExistingCluster != nil && *testEnv.UseExistingCluster == true {
+			if testEnv.UseExistingCluster != nil && *testEnv.UseExistingCluster {
 				namespaceDeletionSupported = true
 			}
 

diff --git a/controllers/suite_test.go b/controllers/suite_test.go
@@ -147,7 +147,7 @@ var _ = BeforeSuite(func() {
 		},
 	}
 
-	if testEnv.UseExistingCluster != nil && *testEnv.UseExistingCluster == true {
+	if testEnv.UseExistingCluster != nil && *testEnv.UseExistingCluster {
 		namespaceDeletionSupported = true
 	}
 

diff --git a/controllers/vrg_volrep_test.go b/controllers/vrg_volrep_test.go
@@ -1481,7 +1481,7 @@ func (v *vrgTest) verifyPVCBindingToPV(shouldBeBound bool) {
 		Eventually(func() bool {
 			pvc := getPVC(v.pvcNames[i])
 
-			if shouldBeBound == true {
+			if shouldBeBound {
 				return pvc.Status.Phase == corev1.ClaimBound
 			}
 
@@ -1543,7 +1543,7 @@ func (v *vrgTest) verifyVRGStatusExpectation(expectedStatus bool) {
 			return false
 		}
 
-		if expectedStatus == true {
+		if expectedStatus {
 			// reasons for success can be different for Primary and
 			// secondary. Validate that as well.
 			switch vrg.Spec.ReplicationState {