drenv: Fix submariner for MacOS #1497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Mac, the check for certs is more strict and it fails for submariner service. Turning off the check for certs. More info: golang/go#51991 Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
nirs
reviewed
Jul 24, 2024
| """ | ||
| Run subctl join ... logging progress messages. | ||
| """ | ||
| args = ["join", broker_info, "--context", context, "--clusterid", clusterid] | ||
| args.append(f"--check-broker-certificate={check_broker_certificate}") |
There was a problem hiding this comment.
This will add:
--check-broker-certificate=True
Which may not work since it should use "true|false".
Since by default subctl checks certs, we can do this:
if not check_broker_certificates:
args.append("--check-broker-certificate=false")
| @@ -60,6 +60,7 @@ def join_cluster(cluster, broker_info): | |||
| clusterid=cluster, | |||
| cable_driver="vxlan", | |||
| version=VERSION, | |||
| check_broker_certificate=False, | |||
There was a problem hiding this comment.
Do we want to do this only on macOS? It would be nice to detect real issues with certificates when we can.
|
Closing as it was fixed in #1536 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mac, the check for certs is more strict and it fails for submariner
service. Turning off the check for certs.
More info: golang/go#51991
Signed-off-by: Raghavendra Talur raghavendra.talur@gmail.com