hack: customize script for OS type #1499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
nirs
reviewed
Jul 25, 2024
There was a problem hiding this comment.
These bash scripts become more complicated and using bash cryptic syntax make it harder to maintain. This should move into drenv since it is about checking tools needed by drenv.
We already have a "drenv setup" that can be used to check or better deploy the required tools.
| exit 1 | ||
| fi | ||
| done | ||
| fi |
There was a problem hiding this comment.
This is unneeded duplication. We could do this instead:
if linux:
append virt-host-validate to commands
And use single loop for checking if commands exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prerequisites are different on MacOS than on Linux. Customize the script accordingly.