Label PVCs for consistency groups #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
ELENAGER
force-pushed
the
label_pvcs_for_cg
branch
from
d78151e
to
f3e8ac8
Compare
youhangwang
approved these changes
Aug 3, 2024
|
/lgtm I will add a for loop to add the cg label in cephfs PVCs in func |
BenamarMk
reviewed
Aug 5, 2024
| @@ -694,6 +701,54 @@ func (v *VRGInstance) updatePVCList() error { | |||
| return v.separatePVCsUsingStorageClassProvisioner(pvcList) | |||
| } | |||
|
|
|||
| func (v *VRGInstance) labelPVCsForCG() error { | |||
There was a problem hiding this comment.
I am just mentioning a conversation we had in another PR here: #1472 (comment)
This works for now. We will just have one CG per DRPC.
par97
pushed a commit
to par97/ramen
that referenced
this pull request
Aug 8, 2024
Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
asn1809
pushed a commit
to asn1809/ramen
that referenced
this pull request
Aug 21, 2024
Signed-off-by: Elena Gershkovich <elenage@il.ibm.com> Signed-off-by: Annaraya Narasagond <annaraya.narasagond@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding label "ramendr.openshift.io/consistency-group" to PVCs if consistency group is enable in DRPC.