vrg: remove the use of captureStartConditionally #1532
Commits on Sep 6, 2024
-
drpc conditions in wide output
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
-
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
-
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
-
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
-
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
-
tests: keep all suite cleanup functions in suite_test.go
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
-
tests: dump the kubeconfig for the testenv server
This is going to be useful to inspect the state of the cluster after a test fails. Set the env variable SKIP_CLEANUP to "true" or "1" to skip the cleanup of the environment to make use of the kubeconfig. The kubeconfig is dumped in the testbin directory. After debugging you will have to kill the testEnv. The two binaries that are used by the testEnv are etcd and kube-apiserver. Check for the running process with a command like ps aux | grep -e kube-apiserver -e etcd Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
-
hack: customize script for OS type
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
-
drenv: turn off check for broker certs
On Mac, the check for certs is more strict and it fails for submariner service. Turning off the check for certs. More info: golang/go#51991 Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
-
vrg: remove the use of captureInProgressStatusUpdate
captureInProgressStatusUpdate was a function pointer that was an empty function when the VRG was being reconciled as Primary and a call to VRGConditionReasonUploading with status false when reconciling as Secondary in the relocate case. Simplify the code by removing the function pointer. * Remove the captureInProgressStatusUpdate parameter from kubeObjectsProtect kubeObjectsCaptureStartOrResumeOrDelay kubeObjectsCaptureStartOrResume kubeObjectsGroupCapture. Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
-
vrg: remove the use of captureStartConditionally
captureStartConditionally was a function pointer that was * capturing kube objects one last time when the vrg was secondary * capturing kube objects if time since last capture was greater than the capture interval Refactored into one function that performs the capture based on the vrg spec. Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.