Support workdir venv #1548
Open
Support workdir venv #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ELENAGER
approved these changes
Sep 19, 2024
|
Needs rebase after main changed. |
When using CI, we want to use a fresh venv for every build so bad venv
created by one job does not break the next job, or bad change in a PR is
not hidden by good venv created by a previous job.
When using local development, you may want to have venv per ramen source
directory. One case is using git worktree to have multiple ramen trees.
With this change you can create a venv per ramen worktree.
Example usage:
hack/make-venv .venv/ramen
Since this is the expected usage, add this path to gitignore, so using
`git clean dxf` does not remove the directory.
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Create venv inside the ramen checkout directory to have fresh venv for every build. Since drenv is not installed on the runner, we need to enter the venv in any step script. I hope we can find a way to enter the venv once for the entire job, but this is good enough for now. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support creating venv per workdir:
With this you can test drenv changes in the ramen-foobar worktree without affecting the main worktree, using the standard venv (~/.venv/ramen).
Use this in the CI to ensure that every build uses a fresh venv instead of installing drenv on the runner host.