Add macOS CI #1556
Open
Add macOS CI #1556
+97
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
force-pushed
the
lima-ci
branch
2 times, most recently
from
58295e0
to
42bca11
Compare
nirs
force-pushed
the
lima-ci
branch
2 times, most recently
from
d551309
to
cb75e33
Compare
nirs
commented
Sep 18, 2024
nirs
force-pushed
the
lima-ci
branch
3 times, most recently
from
bbed4c9
to
adfa713
Compare
nirs
force-pushed
the
lima-ci
branch
7 times, most recently
from
8fc944a
to
730d71d
Compare
The `test` target depends now on `unit-test` and `cluster-test` targets, so developers that started a test cluster can easily run all tests, but tests that do not depend on a test cluster can run when test cluster is not available. The `unit-test` target runs only tests that do not need a test cluster. The `cluster-test` target runs only tests that needs a test cluster. The `test` cluster run both sub targets. Each sub-target add coverage data to the coverage file. The `coverage` target show the coverage add by all the sub-targets. To clear coverage data, you can use the new `coverage-clean` target. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Add basic tests for drenv skipping the tests requiring a test cluster which we cannot use yet. Github provides Intel based macOS runners supporting nested virtualization. We can start a lima vm but it always get stuck waiting for ssh connection to the guest. We can try to fix this later, but for now we can run all the test that do not require a test cluster by skipping the tests. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
requested review from
raghavendra-talur,
ShyamsundarR,
BenamarMk and
rakeshgm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic tests for drenv skipping the tests requiring a test cluster
which we cannot use yet.
Github provides Intel based macOS runners supporting nested
virtualization. We can start a lima vm but it always get stuck waiting
for ssh connection to the guest. We can try to fix this later, but for
now we can run all the test that do not require a test cluster by
skipping the tests.