Add volsync block based self test #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
force-pushed
the
volsync-block
branch
11 times, most recently
from
bba8ad1
to
329a6d9
Compare
nirs
force-pushed
the
volsync-block
branch
2 times, most recently
from
a5f5d81
to
eed0c22
Compare
We need this for testing volsync with block devices. For lima vms we will need this later when we have nested virtualization for kubevirt vm. For minikube clusters this change is done via the environment file which is nicer, but it requires configuring containerd after the cluster has started, which can cause failures in addons scripts. For lima clusters we don't have an easy way to make the configuration conditional. The configuration is baked in the provisioning scripts so contained starts with this configuration. We need to upstream this change to minikube later. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
force-pushed
the
volsync-block
branch
3 times, most recently
from
8c4a0f1
to
0702f96
Compare
Self tests should use {addon}-test namespace to make the tests easier to
debug.
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
VolSync support 2 modes: creating the destination pvc or using existing pvc. To support block pvcs we need to create the pvc. Changing the test to use create a pvc so it is easy to add a second test using block mode. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
changed the title
nirs
requested review from
raghavendra-talur,
rakeshgm,
ShyamsundarR and
ELENAGER
nirs
commented
Oct 14, 2024
nirs
removed request for
raghavendra-talur,
rakeshgm,
ShyamsundarR,
BenamarMk and
ELENAGER
We need to kustomize both the application and the replication source for file and block, and we install them separately. So we need 2 directories. Using the common shortcuts used by ramen rs (replication source) and rd (replication destination). Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Rewrite the resource and test script to use kustomization. The first overlay is file (app/file, rs/file, rd/file). Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Add an overlay using rook-ceph-block pvc. We deploy and both test in parallel. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test both file (cephfs) and block (rbd) pvcs with volsync.
The new layout: