Adjust drenv to support consistency groups #1564
Conversation
hack/minikube-rook-mirror-setup.sh
Outdated
There was a problem hiding this comment.
We don't need to maintain this file - we plan to delete minikube bash based scripts soon.
You can keep it if you want but nobody is maintaining these files.
| @@ -268,4 +276,7 @@ wait_until_pool_mirroring_is_healthy(cluster2) | |||
| deploy_vrc_sample(cluster1) | |||
| deploy_vrc_sample(cluster2) | |||
|
|
|||
| deploy_vgrc_sample(cluster1) | |||
| deploy_vgrc_sample(cluster2) | |||
There was a problem hiding this comment.
This looks fine, but it would be little bit nicer to group all the resources in a kustomization directory and apply all of them with one command, if you want to try.
ELENAGER
force-pushed
the
drenv_with_cg
branch
6 times, most recently
from
27e747c
to
9eb2ffc
Compare
ELENAGER
changed the title
ELENAGER
force-pushed
the
drenv_with_cg
branch
from
9eb2ffc
to
4342e4b
Compare
| @@ -6,6 +6,8 @@ apiVersion: storage.k8s.io/v1 | |||
| kind: StorageClass | |||
| metadata: | |||
| name: rook-ceph-block | |||
| labels: | |||
| ramendr.openshift.io/storageid: rook-ceph-storage-id | |||
There was a problem hiding this comment.
Ideally the storage ID should be different in the 2 clusters, as this is not a MetroDR setup. So in this case, we should "maybe" add the value with the cluster name to start with.
If we specify the same storage ID, as we develop peer classes at the hub DRPolicy would assume that this is a metro setup in the future.
There was a problem hiding this comment.
This will need attention, if not now then pretty soon as we add code for update DRPolicy.status.peerLists as per #1403
Does not block this PR as such, but something to correct down the line.
Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
ELENAGER
force-pushed
the
drenv_with_cg
branch
from
1fcb1f6
to
d65e167
Compare
Add volume group replication class to drenv