Kustomize rbd-mirror directory #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ELENAGER
force-pushed
the
kustomize_rbd_mirror_test
branch
3 times, most recently
from
7fef775
to
026b344
Compare
nirs
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Arranging the resource for volume replication and volume group replication makes looks reasonable, but is wrong for the way these resources are used. We need one kustomization for the start hook, and another for the test hook.
The layout can be something like:
├── README.md
├── start
├── start-data
│ ├── kustomization.yaml
│ ├── rbd-mirror-secret.yaml
│ ├── rbd-mirror.yaml
│ └── vrc-sample.yaml
├── test
└── test-data
├── kustomization.yaml
├── rbd-pvc.yaml
└── vr-sample.yamlNote that rbd-mirror-secret.yaml is a template and we cannot deploy it using kustomization, but we can reploy rbd-mirror.yaml and vrc-sample.yaml using the kustomization.
This generic structure can work for lot of other addons and make this part is easier to maintain.
ELENAGER
force-pushed
the
kustomize_rbd_mirror_test
branch
4 times, most recently
from
f135d48
to
9a61448
Compare
nirs
reviewed
Sep 23, 2024
ELENAGER
force-pushed
the
kustomize_rbd_mirror_test
branch
4 times, most recently
from
583fd54
to
e85b0c3
Compare
Done |
ELENAGER
force-pushed
the
kustomize_rbd_mirror_test
branch
4 times, most recently
from
45780ac
to
3aab5ab
Compare
Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
ELENAGER
force-pushed
the
kustomize_rbd_mirror_test
branch
from
3aab5ab
to
ec040ae
Compare
nirs
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following comment: #1564 (comment)