Update to latest version of the recipe API #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asn1809
reviewed
Sep 24, 2024
Command run: `go get -u github.com/ramendr/recipe` Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com> Co-Authored-by: Annaraya Narasagond <annarayanarasagond@gmail.com>
raghavendra-talur
force-pushed
the
rtalur-update-recipe-ref
branch
from
e9f096d
to
ad7c3ab
Compare
Changes are: 1. Find the backup and restore workflow by name as CaptureWorkflow and RecoverWorkflow don't exist anymore. 2. Change timeout to int 3. Change command to string type Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com> Co-Authored-by: Annaraya Narasagond <annarayanarasagond@gmail.com>
raghavendra-talur
force-pushed
the
rtalur-update-recipe-ref
branch
from
4a8e36d
to
54c208a
Compare
Command run: `go get -u github.com/ramendr/ramen/api/v1alpha1` Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
raghavendra-talur
force-pushed
the
rtalur-update-recipe-ref
branch
from
54c208a
to
3b85faa
Compare
|
LGTM. |
ShyamsundarR
approved these changes
Sep 25, 2024
This is to support packaging and providing recipe CRDs to any cluster, as the application would be created with a recipe. So the thought process is that and app bundle can be delivered to a cluster that includes the Recipe, when that app/cluster is DR protected Ramen would use the recipe. To aid app devs to craft and bundle the recipe it is provided as a separate repo. |
BenamarMk
approved these changes
Sep 26, 2024
BenamarMk
added a commit
to red-hat-storage/ramen
that referenced
this pull request
Oct 10, 2024
Bug 2280927: Backport of upstream PR RamenDR#1573
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.modfile to use the newer version of the Recipe APICaptureWorkflowandRecoverWorkflow) with the appropriate backup and restore workflow names.Fixed tests.
Co-Authored-by: @asn1809