Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Velero integration in the test environment #903

Merged
merged 7 commits into from
Jul 5, 2023
Merged

Velero integration in the test environment #903

merged 7 commits into from
Jul 5, 2023

Conversation

nirs
Copy link
Member

@nirs nirs commented May 30, 2023 •
edited
Loading

Integrate velero in the test environment, installing velero on the managed clusters.

The velero addon has now a self test verifying that velero backup and restore work
on a single cluster

The self test uses nginx deployment copied from velero release tarball with a fix for
vmware-tanzu/velero#6347.

ramenctl config was updated to configure ramen velero options, mainly the special
cloud secret generated by the velero install run by the velero addon.

The velero tool is new requirement that must be installed manually like other tools. We
may want to improve this later.

Ramen kube object protection was not tested yet with this change.

Resolves #662

hatfieldbrian
hatfieldbrian approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@hatfieldbrian hatfieldbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a few minor changes to Ramen config map

ramenctl/ramenctl/resources/configmap.yaml Outdated Show resolved Hide resolved
ramenctl/ramenctl/resources/configmap.yaml Outdated Show resolved Hide resolved
ramenctl/ramenctl/resources/configmap.yaml Outdated
VeleroNamespaceSecretKeyRef:
key: cloud
name: cloud-credentials
veleroNamespaceName: velero
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be under kubeObjectProtection:, or it could be omitted as velero is the default value

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, The changes were copied from

ramen/hack/recipe_e2e/config/ramen_config_base.yaml

Line 39 in 99f7ab6

veleroNamespaceName: "velero"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjanssen3 I wonder if the config map referenced above is used by recipe_e2e? It seems a few of the field identifiers are wrong. Since this is not a CRD the usual API server checking is missing...maybe the fields are simply ignored, which would be fine for the Velero namespace name which defaults to velero, but the secret name and key do not have defaults.

@nirs nirs force-pushed the velero branch 2 times, most recently from cdd01bf to 681c3fb Compare June 1, 2023 21:59
@nirs nirs requested a review from hatfieldbrian June 1, 2023 22:00
@nirs nirs force-pushed the velero branch 5 times, most recently from 3d5e662 to f61122d Compare June 2, 2023 00:56
@nirs nirs marked this pull request as ready for review June 2, 2023 00:56
@nirs nirs force-pushed the velero branch 2 times, most recently from f5853a9 to 0ce8c1c Compare June 2, 2023 16:49
nirs added a commit to nirs/ramen that referenced this pull request Jun 2, 2023
@nirs
Add regional dr environment without a hub
94ec243 
For testing kube object projection in a setup without a hub.

Work in progress:
- Need to update `ramenctl deploy` to skip the missing hub
- Need to update `ramenctl config` to configure the dr clusters instead
  of the hub

Based temporarily on RamenDR#903

Part-of: RamenDR#902
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
@nirs nirs mentioned this pull request Jun 2, 2023
Merged
nirs added a commit to nirs/ramen that referenced this pull request Jun 2, 2023
@nirs
Add regional dr environment without a hub
3fa47d1 
For testing kube object projection in a setup without a hub.

Work in progress:
- Need to update `ramenctl deploy` to skip the missing hub
- Need to update `ramenctl config` to configure the dr clusters instead
  of the hub

Based temporarily on RamenDR#903

Part-of: RamenDR#902
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this pull request Jun 2, 2023
@nirs
Add regional dr environment without a hub
5b3d9b1 
For testing kube object projection in a setup without a hub.

Based temporarily on RamenDR#903

Part-of: RamenDR#902
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this pull request Jun 2, 2023
@nirs
Add regional dr environment without a hub
532a741 
For testing kube object projection in a setup without a hub.

Based temporarily on RamenDR#903

Part-of: RamenDR#902
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this pull request Jun 2, 2023
@nirs
Add regional dr environment without a hub
26dd93d 
For testing kube object projection in a setup without a hub.

Based temporarily on RamenDR#903

Part-of: RamenDR#902
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
@nirs nirs mentioned this pull request Jun 2, 2023
Open
nirs added a commit to nirs/ramen that referenced this pull request Jun 7, 2023
@nirs
Add regional dr environment without a hub
6f6d19c 
For testing kube object projection in a setup without a hub.

Based temporarily on RamenDR#903

Part-of: RamenDR#902
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
hatfieldbrian
hatfieldbrian approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@hatfieldbrian hatfieldbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nirs added a commit to nirs/ramen that referenced this pull request Jun 25, 2023
@nirs
Add regional dr environment without a hub
10e2974 
For testing kube object projection in a setup without a hub.

Based temporarily on RamenDR#903

Part-of: RamenDR#902
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this pull request Jun 25, 2023
@nirs
Add regional dr environment without a hub
37d7511 
For testing kube object projection in a setup without a hub.

Based temporarily on RamenDR#903

Part-of: RamenDR#902
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
@nirs
Copy link
Member Author

nirs commented Jun 25, 2023

Changes since @hatfieldbrian review:

  • Rebase on main
  • Adding missing credetials.conf to the commit deploying velero (was included by mistake in the commit adding the self test)

nirs added a commit to nirs/ramen that referenced this pull request Jul 3, 2023
@nirs
Add regional dr environment without a hub
7768ce7 
For testing kube object projection in a setup without a hub.

Based temporarily on RamenDR#903

Part-of: RamenDR#902
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
@nirs
Copy link
Member Author

nirs commented Jul 3, 2023

Rebased on main to fix conflicts with merged submariner pr.

ELENAGER
ELENAGER reviewed Jul 4, 2023
View reviewed changes
test/addons/velero/test Outdated Show resolved Hide resolved
ELENAGER
ELENAGER reviewed Jul 4, 2023
View reviewed changes
test/addons/velero/test Outdated Show resolved Hide resolved
@nirs nirs marked this pull request as draft July 4, 2023 14:08
nirs added a commit to nirs/ramen that referenced this pull request Jul 4, 2023
@nirs
Add regional dr environment without a hub
dc2f1ac 
For testing kube object projection in a setup without a hub.

Based temporarily on RamenDR#903

Part-of: RamenDR#902
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
@nirs nirs marked this pull request as ready for review July 4, 2023 15:24
@nirs nirs requested a review from ELENAGER July 4, 2023 15:24
nirs added 7 commits July 4, 2023 18:30
@nirs
Move minio module to drenv
e8286a8 
Promote ramenctl.minio helper module to drenv.minio so we can use it in
the velero addon. This is module is not really generic and depend on the
specific way we deploy the minio addon, but we don't have a better place
for this now.

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
@nirs
Add velero to required tools for drenv
6023212 
To install and debug *Velero* we need the `velero` tool. Add it to the
required tools list like all other tools.

I think we can simplify this later by installing the tools
automatically, but we can improve this later.

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
@nirs
Add minimal velero environment
9e399a7 
For testing velero it is much faster to use a small and simpler
environment.

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
@nirs
Deploy velero on the cluster
577f612 
Use the velero command (new requirement) to install velero on the
managed clusters.

Installing velero also installs velero crds, so previous code to install
them was removed.

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
@nirs
Add velero self test
062b746 
The test deploy nginx, creates a backup, delete the namespace and store
nginx from the backup. Finally it cleans up so we don't leave anything
on the cluster.

The test is idempotent - if the tests fails and leave junk around, the
next run will delete backups and restores and start from scratch.

Issues:

- Restore completes successfully - but has a warning. The deployment
  looks correct and the warning looks like expected behavior when
  backing up all resources blindly.

    $ velero restore get
    NAME                          BACKUP         STATUS      STARTED                         COMPLETED                       ERRORS   WARNINGS   CREATED                         SELECTOR
    nginx-backup-20230602013503   nginx-backup   Completed   2023-06-02 01:35:03 +0300 IDT   2023-06-02 01:35:04 +0300 IDT   0        1          2023-06-02 01:35:03 +0300 IDT   <none>

    $ velero restore describe | grep Warn
    Warnings:
        nginx-example:  could not restore, Endpoints "my-nginx" already
        exists. Warning: the in-cluster version is different than the
        backed-up version.

    $ kubectl get all -n nginx-example
    NAME                                    READY   STATUS    RESTARTS   AGE
    pod/nginx-deployment-7c89967545-zgb7h   1/1     Running   0          41s
    pod/nginx-deployment-7c89967545-zrf2s   1/1     Running   0          41s

    NAME               TYPE           CLUSTER-IP      EXTERNAL-IP   PORT(S)        AGE
    service/my-nginx   LoadBalancer   10.103.206.98   <pending>     80:32334/TCP   41s

    NAME                               READY   UP-TO-DATE   AVAILABLE   AGE
    deployment.apps/nginx-deployment   2/2     2            2           41s

    NAME                                          DESIRED   CURRENT   READY   AGE
    replicaset.apps/nginx-deployment-7c89967545   2         2         2       41s

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
@nirs
Rename ramen s3 secret
2c2ea1a 
We need to add a velero s3 secret for the velero bucket. Rename the
ramen s3 secret to so we can have consistent and clear names.

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
@nirs
Add velero configuration to ramenctl config
41eb99c 
Velero uses the same s3 bucket using the same s3 profile, but it needs a
different secret stored at `veleroNamespaceSecretKeyRef`.  The secret is
created by `velero install`.

Seems to be complete, but not tested with ramen yet.

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs added a commit to nirs/ramen that referenced this pull request Jul 4, 2023
@nirs
Add regional dr environment without a hub
1269228 
For testing kube object projection in a setup without a hub.

Based temporarily on RamenDR#903

Part-of: RamenDR#902
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
@nirs nirs merged commit c669b6e into RamenDR:main Jul 5, 2023
9 checks passed
nirs added a commit to nirs/ramen that referenced this pull request Jul 5, 2023
@nirs
Add regional dr environment without a hub
3bdd3ed 
For testing kube object projection in a setup without a hub.

Based temporarily on RamenDR#903

Part-of: RamenDR#902
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
@nirs nirs mentioned this pull request Jul 5, 2023
Merged
@nirs nirs deleted the velero branch September 7, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ELENAGER ELENAGER ELENAGER approved these changes

@hatfieldbrian hatfieldbrian hatfieldbrian approved these changes

@raghavendra-talur raghavendra-talur Awaiting requested review from raghavendra-talur

@ShyamsundarR ShyamsundarR Awaiting requested review from ShyamsundarR

@tjanssen3 tjanssen3 Awaiting requested review from tjanssen3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Velero integration in test environment
3 participants
@nirs @ELENAGER @hatfieldbrian