Flaky unit test - fails to update DRCluster manifest work #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| types.NamespacedName{Name: mw.Name, Namespace: managedClusternamespace}, | ||
| foundMW) | ||
|
|
||
| if err != nil { |
There was a problem hiding this comment.
What is the purpose of the Get operation here?
Also, if the error we got was a conflict err, should we not retry the update after getting it?
There was a problem hiding this comment.
Inside the RetryOnConflict function we need to do 3 steps:
- Reload manifest work resource
- Update it's status (deepcopy)
- Update the manifest work resource
Get function can't have conflicts, if we failed in it - no need to proceed, it's real error
Update function return value is inspected by RetryOnConflict function itself and the decision if exit or proceed is taken by it.
There was a problem hiding this comment.
In my opinion, implementing this pattern is good for the ManifestWork. Because it can be modified by an external entity at runtime and we have no control over it.
ELENAGER
force-pushed
the
unit_tests_fix
branch
2 times, most recently
from
57fa2d9
to
ba31b3e
Compare
BenamarMk
approved these changes
Jun 22, 2023
Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
raghavendra-talur
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flaky unit test (DRClusterController DRCluster resource CIDR validation when provided CIDR value is changed to be correct [It] reports validated)
Fixes: #901