Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose hyperdrive drive.diff() API #90

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

josephmturner
Copy link
Contributor

@josephmturner josephmturner commented Aug 12, 2023

The code is not quite working yet. I suspect I'm not returning the stream in the response body correctly.

EDIT: Figured it out!

@josephmturner
Copy link
Contributor Author

Resolves #51

@josephmturner josephmturner force-pushed the wip/diff branch 2 times, most recently from ee99adf to ba32e97 Compare August 14, 2023 04:50
Copy link
Owner

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what do you think of having the ability to omit the ... and just have one version number. This would be similar to the githib syntax where you compare to the main branch. In our case it would compare against the latest version of the drive.

README.md Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@RangerMauve
Copy link
Owner

feel free to use 2 dots

@josephmturner josephmturner force-pushed the wip/diff branch 2 times, most recently from a390074 to 397c163 Compare August 19, 2023 01:44
@josephmturner
Copy link
Contributor Author

Also, what do you think of having the ability to omit the ... and just have one version number. This would be similar to the githib syntax where you compare to the main branch. In our case it would compare against the latest version of the drive.

Good idea! I just force-pushed this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants