Adding Slither to CI #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently |
|
Slither now returns the following: cache is already set to |
|
It's an error with forge, add an issue here. |
|
@pedrommaiaa thanks for looking into this! |
|
I noticed Foundry is planning to integrate it in their template, could be a good reference: foundry-rs/forge-template#49 |
|
Let's keep an eye on both PRs, should work after they are both solved/merged. |
This was referenced May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP #20
Slither and a Github code scanning integration were added to
ci.yml.Slither is currently failing with error:
ERROR:CryticCompile:Solidity version not found: No solc version set.