Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data validation is too brute #8

Open
dimaursu opened this issue Jan 23, 2015 · 1 comment
Open

Data validation is too brute #8

dimaursu opened this issue Jan 23, 2015 · 1 comment

Comments

@dimaursu
Copy link

https://github.com/Raven24/diaspora-federation/blob/master/lib/diaspora-federation/salmon/encrypted_slap.rb#L115

This is kinda harsh for developers, requiring to have author_id of type string. We can convert that on our own, with a simple .to_s ; I think it's more important to check if all the content of author_id are digits.

@dimaursu dimaursu changed the title Data validation is too harsh Data validation is too brute Jan 23, 2015
@Raven24
Copy link
Owner

Raven24 commented Jan 24, 2015

yeah, you're probably right... that's one of my java-isms when I don't remember ruby supports duck typing ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants