test tweaks

RcppCore · Jun 11, 2024 · 528f453 · 528f453
1 parent 2520e51
commit 528f453
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/inst/tinytest/cpp/Vector.cpp b/inst/tinytest/cpp/Vector.cpp
@@ -888,13 +888,11 @@ bool CharacterVector_test_equality_crosspolicy(CharacterVector x, Vector<STRSXP,
 }
 
 // [[Rcpp::export]]
-double NumericVector_test_out_of_bounds_read() {
-    NumericVector v(3);
-    return v[5];
+double NumericVector_test_out_of_bounds_read(NumericVector v, R_xlen_t i) {
+    return v[i];
 }
 
 // [[Rcpp::export]]
-SEXP CharacterVector_test_out_of_bounds_read() {
-    CharacterVector v(3);
-    return v[5];
+SEXP CharacterVector_test_out_of_bounds_read(CharacterVector v, R_xlen_t i) {
+    return v[i];
 }
diff --git a/inst/tinytest/test_vector.R b/inst/tinytest/test_vector.R
@@ -695,6 +695,9 @@ expect_equal(data, data2)
 expect_true( !CharacterVector_test_equality("foo", "bar") )
 expect_true( !CharacterVector_test_equality_crosspolicy("foo", "bar") )
 
+# https://github.com/RcppCore/Rcpp/issues/1308
+expect_error(NumericVector_test_out_of_bounds_read(numeric(0), 0))
+expect_error(NumericVector_test_out_of_bounds_read(numeric(1), 1))
+expect_error(CharacterVector_test_out_of_bounds_read(character(0), 0))
+expect_error(CharacterVector_test_out_of_bounds_read(character(1), 1))
 
-expect_error(NumericVector_test_out_of_bounds_read())
-expect_error(CharacterVector_test_out_of_bounds_read())