Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force loading bit64 earlier in print() #6227

Merged
merged 1 commit into from
Jul 8, 2024
Merged

force loading bit64 earlier in print() #6227

merged 1 commit into from
Jul 8, 2024

Conversation

MichaelChirico
Copy link
Member

Closes #6224

My first thought was to add a format_col.integer64 method, but it turns out the fix is much easier, just need to force loading {bit64} one line earlier.

Copy link

github-actions bot commented Jul 8, 2024

Comparison Plot

Generated via commit cbba51a

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 12 minutes and 24 seconds

Time taken to run atime::atime_pkg on the tests: 3 minutes and 20 seconds

Copy link
Member

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thanks
nice test

@MichaelChirico MichaelChirico merged commit c687701 into master Jul 8, 2024
4 checks passed
@MichaelChirico MichaelChirico deleted the print-i64 branch July 8, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect printing of integer64 columns
2 participants