Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode for all sites #46

Open
1 of 7 tasks
rohan09-raj opened this issue Dec 27, 2021 · 1 comment
Open
1 of 7 tasks

Dark Mode for all sites #46

rohan09-raj opened this issue Dec 27, 2021 · 1 comment
Assignees

Comments

@rohan09-raj
Copy link

rohan09-raj commented Dec 27, 2021

Color Palette

image

Naming

colorBackground - #1C1B22
colorNav - #191970
colorLink - #0080FF
colorHighlight - #FF0090
colorText - #E1E1EC
colorCardBg - #312F3B

Toggle Icons

Will not be using icon images in current dark-mode update

Light Mode

https://cdn.discordapp.com/attachments/876156184187502622/893489343371546684/sun.png

Dark Mode

https://cdn.discordapp.com/attachments/876156184187502622/893550385409712128/moon.png

Cookie

cookie-name : theme
cookie-value: dark/light
cookie-expiry period: 1 month
domain: .realdevsquad.com

Note

  • Put all color values for lightmode under .lightTheme and for darkmode under .darkTheme classes respectively
  • Create a separate function for adding cookie
  • Feel free to add new colors if needed for the site and have a proper name for which it is, don't change the color values of existing colors given on the color palette

New requirements :

  • Use cookie as the behind the feature flag.
  • On cookieValueChange trigger the new theme.
  • Hide the toggle button as of now.
  • Use the dev console for changing the theme.

There might be slight changes in implementation according to the languages being used for the sites but the main task flow remains the same.

For any queries drop the questions in #dark-mode-feature channel

@akshay1502
Copy link

New requirements

  • remove the toggle icon
  • use the console for changing cookie value
  • remove the functions attached with toggle icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants