fix: staging issue for remove unverified role on /verify #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please mention what was the issue happening in the staging ?? doesn't give me any context |
Issue was roles not getting removed from firestore db as it shouldn't be present there which I found out that for a new user joining RDS discord, unverified role only gets added in the discord and not in the db. So no point of removing from db. This was a mistake from my end, should've checked it earlier. |
|
Okay Just Add it in the PR description would be handy for other reviewer |
prakashchoudhary07
requested changes
Nov 2, 2024
shobhan-sundar-goutam
force-pushed
the
feat/remove-unverified-role
branch
from
e59507b
to
6b849e5
Compare
prakashchoudhary07
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 01/10/24
Developer Name: Shobhan Sundar Goutam
Issue Ticket Number
Description
This PR fixes the staging issue for #2192
Issue was roles not getting removed from firestore db as it shouldn't be present there which I found out that for a new user joining RDS discord, unverified role only gets added in the discord and not in the db. So no point of removing from db.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
discord-verify.mp4
Test Coverage
Screenshot 1