Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop tests on push #283

Open
RitikJaiswal75 opened this issue Aug 22, 2022 · 4 comments · May be fixed by #303
Open

Stop tests on push #283

RitikJaiswal75 opened this issue Aug 22, 2022 · 4 comments · May be fixed by #303
Assignees

Comments

@RitikJaiswal75
Copy link
Contributor

Issue

  • When a PR is created, the git workflow runs tests on all the pull requests, but once the tests are run on pull requests they run again during push

When was the issue discovered?

  • The issue was discovered on 18th August 2022 during a hangout call while trying to merge PRs.

Files that might be creating this

  • .github/workflows/test.yml

Screenshot of the Problem

image

@bajajcodes
Copy link
Contributor

bajajcodes commented Jan 20, 2023

Hey @RitikJaiswal75 can you assign this issue to me?
Assigned, and PR raised.

@MehulKChaudhari
Copy link
Member

Hey, I think it's good that the tests are run after every commit. It gives us an idea of which commits made the tests fail.

@bajajcodes
Copy link
Contributor

Hey, I think it's good that the tests are run after every commit. It gives us an idea of which commits made the tests fail.

This can be done locally as well, if TDD is followed.

@MehulKChaudhari
Copy link
Member

Hey, I think it's good that the tests are run after every commit. It gives us an idea of which commits made the tests fail.

This can be done locally as well, if TDD is followed.

Yes, But what if developer didn't fix the tests which are breaking or didn't run tests locally? how will reviewer know whether there are breaking changes or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants