Feat/add new dashboard UI #299
Open
+1,109
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changes in navbar UI and content * Change in navbar UI * Change in navbar UI as per new design * Add login url from constants * Added changes to fetch and display data for signed-in users * Fixed display data for signed-out users * Added mobile UI change for currency exchange page * Added changes to use Link component for anchor tags * Remove commented code * css code refactor changes * Add and load paths from constants file * Remove !important property from navbar css * Refactor css code * Add UI changes in navbar * Add default avatar for user profile picture * Add UI changes in navbar * Add UI changes in navbar * Add profile link on greet message & error handling in fetch user * Fix profile url * Added .env.development file (Real-Dev-Squad#245) Co-authored-by: user.name: "Rohan Raj Gupta <user.email: "rajrohan1914@gmail.com> * Improvement in code and changes to use cloudinary images * Add key prop * Replace useEffect by useLayoutEffect for login button * Improvement in navbar code * Update ecmaVersion in ESLint config * Revert useLayoutEffect changes for login button * Fix login button UI Co-authored-by: Shubham <yadav105shubham@gmail.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: user.name: "Rohan Raj Gupta <user.email: "rajrohan1914@gmail.com>
* Changes in navbar UI and content * Change in navbar UI * Change in navbar UI as per new design * Add login url from constants * Added changes to fetch and display data for signed-in users * Fixed display data for signed-out users * Added mobile UI change for currency exchange page * Added changes to use Link component for anchor tags * Remove commented code * css code refactor changes * Add and load paths from constants file * Remove !important property from navbar css * Refactor css code * Add UI changes in navbar * Add default avatar for user profile picture * Add UI changes in navbar * Add UI changes in navbar * Add profile link on greet message & error handling in fetch user * Fix profile url * Added .env.development file (Real-Dev-Squad#245) Co-authored-by: user.name: "Rohan Raj Gupta <user.email: "rajrohan1914@gmail.com> * Improvement in code and changes to use cloudinary images * Add key prop * Replace useEffect by useLayoutEffect for login button * Improvement in navbar code * Update ecmaVersion in ESLint config * Revert useLayoutEffect changes for login button * Fix login button UI Co-authored-by: Shubham <yadav105shubham@gmail.com> Co-authored-by: Rohan Raj Gupta <78433013+rohan09-raj@users.noreply.github.com> Co-authored-by: user.name: "Rohan Raj Gupta <user.email: "rajrohan1914@gmail.com>
…bsite-crypto into feature/new-sidebar
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
heyrandhir
suggested changes
Jan 30, 2023
|
@manish591 can't find the test in the PR. Are the test already merged 🤔. |
No, the tests are not merged yet. Will write them now |
DeRaowl
suggested changes
Feb 16, 2023
samyakshah3008
previously approved these changes
Feb 18, 2023
DeRaowl
approved these changes
Mar 24, 2023
heyrandhir
approved these changes
Mar 25, 2023
There was a problem hiding this comment.
Great work @manish591! .Would recommend you creating small and incremental PRs in the future. Thank you!
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #272
NOTE: I have taken a pull from Vinayak's PR #274 that is already been reviewed.
Visual Reference