Add Unit Tests for Refactored TaskDetails Subcomponents
#1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for improved maintainability and performance - Broke down TaskDetails component into smaller, focused subcomponents: TaskHeader, TaskDescription, TaskDetailsSection, TaskParticipants, TaskDates, TaskDependencies, and TaskProgress. - Maintained consistent styling using existing CSS classes from task-details.module.scss. - Ensured all functionalities, including editing, API integration, and state management, remain intact. - Added performance optimizations using React best practices, such as useCallback and useMemo where applicable. - Handled loading and error states, as well as edge cases like empty data gracefully.
…nal rendering - Resolved type issues, ensuring is correctly handled as a number. - Fixed conditional rendering to prevent the edit button from appearing for unauthorized users. - Ensured consistent date formatting using utility. - Improved type safety across the TaskDetails subcomponents to prevent future issues. - Maintained all functionality from previous refactor, including state management and API integration.
- Adjusted the position of the 'Status' and 'Link' fields within the TaskDetailsSection component to ensure they are displayed correctly. - Ensured that the 'Status' dropdown is only visible in edit mode and does not appear twice. - Verified that the layout matches the design specifications when switching between view and edit modes.
…onents - Reverted changes in the component structure that affected the layout and styling. - Ensured the CSS classes are applied correctly and match the pre-refactor styling. - Adjusted the JSX structure to maintain the original visual layout.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…Details subcomponents
Achintya-Chatterjee
changed the title
TaskDetails Subcomponents
…ails subcomponents
…kDetails subcomponents
…askDetails subcomponents
10 tasks
…kDetails subcomponents
Achintya-Chatterjee
requested review from
prakashchoudhary07,
iamitprakash,
joyguptaa,
yesyash and
pallabez
…tor-taskdetails-component
…encies components and directly use underlying components
…tor-taskdetails-component
…already used them in underlying taskdetails component
…already used them in underlying taskdetails component
… of ternary operator
…tor-taskdetails-component
…tor-taskdetails-component
ashifkhn
previously approved these changes
Sep 3, 2024
Base automatically changed from
feature/refactor-taskdetails-component
to
develop
September 3, 2024 12:04
iamitprakash
dismissed stale reviews from ashifkhn, tejaskh3, and themself
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date:
29 August, 2024Developer Name: @Achintya-Chatterjee
Issue Ticket Number
TaskDetailsSubcomponents #1244Description
This PR adds comprehensive unit tests for the newly refactored subcomponents of the
TaskDetailscomponent. These tests ensure the correct functionality of each subcomponent and maintain the overall integrity of theTaskDetailsfeature after its modularization.Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes
These tests focus on ensuring that the refactoring of the
TaskDetailscomponent into smaller subcomponents has not introduced any regressions. The tests have been executed and confirmed to pass successfully, providing confidence in the refactored code's stability.