Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to Main Sync #1247

Merged
merged 27 commits into from
Sep 7, 2024
Merged

Dev to Main Sync #1247

merged 27 commits into from
Sep 7, 2024

Commits on Jul 31, 2024

  1. Configuration menu
    Copy the full SHA
    d13cdab View commit details
    Browse the repository at this point in the history
  2. feat: Update TaskDetails component and fix test for assignee input

    - Updated TaskDetails component to include assignee input with a data-testid of 'assignee-input'.
    - Modified the test for rendering the assignee dropdown to correctly identify the assignee input field using the updated test ID.
    - Ensured the test checks for the presence of the assignee input field in edit mode.
    Achintya-Chatterjee committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    ac7845a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1e5b22e View commit details
    Browse the repository at this point in the history
  4. refactor: Reintroduce getExtensionRequestLink function to TaskDetails…

    … component
    
    - Added back the getExtensionRequestLink function to handle the extension request URL generation.
    - Updated the assignee handling in the render method to include suggestions for editing.
    - Maintained the isEditing and isUserAuthorized checks for showing the assignee input field.
    - Ensured the task extension request link is correctly generated and displayed in the Dates section.
    Achintya-Chatterjee committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    62f7c49 View commit details
    Browse the repository at this point in the history
  5. fix: Resolve duplicate input field and suggestion box issues in TaskD…

    …etails
    
    - Fixed issue with duplicate input fields appearing in the Assignee section.
    - Ensured the suggestion box appears correctly below the Assignee input field.
    - Applied consistent styling to the Assignee input field and suggestion box.
    - Linked the label to the input field using the  attribute.
    - Refactored the Assignee input and suggestion box to use the Suggestions component properly.
    Achintya-Chatterjee committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    58050a7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    38d966d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e229123 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. fix: Ensure consistent width for suggestion box and refactor styles

    - Updated suggestion box styles to maintain a consistent width relative to the input field
    - Ensured suggestion box width is set to 100% of its parent container
    - Adjusted styles for better visual consistency
    Achintya-Chatterjee committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    729d676 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Fix: Assignee text box alignment (#1225)

    * fix: assign text box alignment it would be be appearing where the name is
    
    * feat: Update TaskDetails component and fix test for assignee input
    
    - Updated TaskDetails component to include assignee input with a data-testid of 'assignee-input'.
    - Modified the test for rendering the assignee dropdown to correctly identify the assignee input field using the updated test ID.
    - Ensured the test checks for the presence of the assignee input field in edit mode.
    
    * refactor: make the superuser to false on test files
    
    * refactor: Reintroduce getExtensionRequestLink function to TaskDetails component
    
    - Added back the getExtensionRequestLink function to handle the extension request URL generation.
    - Updated the assignee handling in the render method to include suggestions for editing.
    - Maintained the isEditing and isUserAuthorized checks for showing the assignee input field.
    - Ensured the task extension request link is correctly generated and displayed in the Dates section.
    
    * fix: Resolve duplicate input field and suggestion box issues in TaskDetails
    
    - Fixed issue with duplicate input fields appearing in the Assignee section.
    - Ensured the suggestion box appears correctly below the Assignee input field.
    - Applied consistent styling to the Assignee input field and suggestion box.
    - Linked the label to the input field using the  attribute.
    - Refactored the Assignee input and suggestion box to use the Suggestions component properly.
    
    * fix: classname to be more generic
    
    * refactor: test cases to use those old values
    
    * fix: Ensure consistent width for suggestion box and refactor styles
    
    - Updated suggestion box styles to maintain a consistent width relative to the input field
    - Ensured suggestion box width is set to 100% of its parent container
    - Adjusted styles for better visual consistency
    Achintya-Chatterjee authored Aug 5, 2024
    Configuration menu
    Copy the full SHA
    937f872 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Configuration menu
    Copy the full SHA
    df3401c View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Corrected loading issue and extra space in standup submit (#1230)

    Co-authored-by: Shubham Sharma <shbh541@gmail.com>
    skv93-coder and Shubham Sharma authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    578749f View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. fix: prevent Status field from being displayed twice in TaskDetails c…

    …omponent
    
    Refactored TaskDetails component to conditionally render either the TaskDropDown for editing or the Details component for viewing the status, ensuring the Status field is only displayed once depending on the editing state.
    Achintya-Chatterjee committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    9471dc1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8dfba33 View commit details
    Browse the repository at this point in the history
  3. fix: prevent Status field from being displayed twice in TaskDetails c…

    …omponent
    
    Refactored TaskDetails component to conditionally render either the TaskDropDown for editing or the Details component for viewing the status, ensuring the Status field is only displayed once depending on the editing state.
    Achintya-Chatterjee committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    9a4c6ae View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1231 from Real-Dev-Squad/fix/assignee-text-box

    Fix: Prevent Duplicate `Status:` Field in task details Page
    Achintya-Chatterjee authored Aug 10, 2024
    Configuration menu
    Copy the full SHA
    7bceba4 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Configuration menu
    Copy the full SHA
    31f3308 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f83dfa1 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1237 from Real-Dev-Squad/fix/merge-conflicts

    Fix: merge conflicts
    iamitprakash authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    4bad9e4 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Refactor else condition (#1240)

    * Corrected loading issue and extra space in standup submit
    
    * Fixed early return
    
    ---------
    
    Co-authored-by: Shubham Sharma <shbh541@gmail.com>
    skv93-coder and Shubham Sharma authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    b5cb851 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Fature flag removal of TaskSearch improvement (#1165)

    * removal of feature flag
    
    * fix TaskContent test
    
    * remove TaskSearch deprecated component
    
    * fix test for removing TaskSearch deprecated component
    
    * remove TabSection component
    
    * rename TaskSearchDev to TaskSearch
    
    * rename TaskSearchDev to TaskSearch in tests
    
    * resolve merge conflict
    pallabez authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    62c38d7 View commit details
    Browse the repository at this point in the history
  2. Refactor TaskDetails Component for Improved Maintainability and Per…

    …formance (#1243)
    
    * refactor(TaskDetails): Modularize and optimize TaskDetails component for improved maintainability and performance
    
    - Broke down TaskDetails component into smaller, focused subcomponents: TaskHeader, TaskDescription, TaskDetailsSection, TaskParticipants, TaskDates, TaskDependencies, and TaskProgress.
    - Maintained consistent styling using existing CSS classes from task-details.module.scss.
    - Ensured all functionalities, including editing, API integration, and state management, remain intact.
    - Added performance optimizations using React best practices, such as useCallback and useMemo where applicable.
    - Handled loading and error states, as well as edge cases like empty data gracefully.
    
    * fix(TaskDetails): Correct data type issues and ensure proper conditional rendering
    
    - Resolved type issues, ensuring  is correctly handled as a number.
    - Fixed conditional rendering to prevent the edit button from appearing for unauthorized users.
    - Ensured consistent date formatting using  utility.
    - Improved type safety across the TaskDetails subcomponents to prevent future issues.
    - Maintained all functionality from previous refactor, including state management and API integration.
    
    * fix(task-details): Correct the position of status and link fields
    
    - Adjusted the position of the 'Status' and 'Link' fields within the TaskDetailsSection component to ensure they are displayed correctly.
    - Ensured that the 'Status' dropdown is only visible in edit mode and does not appear twice.
    - Verified that the layout matches the design specifications when switching between view and edit modes.
    
    * chore: remove unnecessary comments from the code
    
    * fix: restore original styling for TaskDates and TaskParticipants components
    
    - Reverted changes in the component structure that affected the layout and styling.
    - Ensured the CSS classes are applied correctly and match the pre-refactor styling.
    - Adjusted the JSX structure to maintain the original visual layout.
    
    * chore: remove react memo from every component as it was unnecessary
    
    * chore: remove react memo from every component as it was unnecessary
    
    * refactor: TaskDates component to conditionally render Details based on extension request status
    
    * refactor: switch to named exports for all of the sub-components
    
    * chore: remove any from TaskDetails component and replace them with appropiates type
    
    * chore: removed default export from every  sub-component as we are already using named export
    
    * refactor(TaskDetails): remove unnecessary TaskProgress and TaskDependencies components and directly use underlying components
    
    * refactor: refactor code to simplyfy code reading used is else instead of ternary operator
    
    * chore: remove extra Taskcontainer wrap that was impacting styling of update progress
    
    ---------
    
    Co-authored-by: Ashif Khan <54736284+ashifkhn@users.noreply.github.com>
    Achintya-Chatterjee and ashifkhn authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    075a72e View commit details
    Browse the repository at this point in the history
  3. Add Unit Tests for Refactored TaskDetails Subcomponents (#1245)

    * refactor(TaskDetails): Modularize and optimize TaskDetails component for improved maintainability and performance
    
    - Broke down TaskDetails component into smaller, focused subcomponents: TaskHeader, TaskDescription, TaskDetailsSection, TaskParticipants, TaskDates, TaskDependencies, and TaskProgress.
    - Maintained consistent styling using existing CSS classes from task-details.module.scss.
    - Ensured all functionalities, including editing, API integration, and state management, remain intact.
    - Added performance optimizations using React best practices, such as useCallback and useMemo where applicable.
    - Handled loading and error states, as well as edge cases like empty data gracefully.
    
    * fix(TaskDetails): Correct data type issues and ensure proper conditional rendering
    
    - Resolved type issues, ensuring  is correctly handled as a number.
    - Fixed conditional rendering to prevent the edit button from appearing for unauthorized users.
    - Ensured consistent date formatting using  utility.
    - Improved type safety across the TaskDetails subcomponents to prevent future issues.
    - Maintained all functionality from previous refactor, including state management and API integration.
    
    * fix(task-details): Correct the position of status and link fields
    
    - Adjusted the position of the 'Status' and 'Link' fields within the TaskDetailsSection component to ensure they are displayed correctly.
    - Ensured that the 'Status' dropdown is only visible in edit mode and does not appear twice.
    - Verified that the layout matches the design specifications when switching between view and edit modes.
    
    * chore: remove unnecessary comments from the code
    
    * fix: restore original styling for TaskDates and TaskParticipants components
    
    - Reverted changes in the component structure that affected the layout and styling.
    - Ensured the CSS classes are applied correctly and match the pre-refactor styling.
    - Adjusted the JSX structure to maintain the original visual layout.
    
    * test: Add unit tests for TaskHeader component of refactored TaskDetails subcomponents
    
    * test: Add unit tests for TaskDescription component of refactored TaskDetails subcomponents
    
    * test: Add unit tests for TaskProgress component of refactored TaskDetails subcomponents
    
    * test: Add unit tests for TaskParticipants component of refactored TaskDetails subcomponents
    
    * test: Add unit tests for TaskDates component of refactored TaskDetails subcomponents
    
    * test: Add unit tests for TaskDetailsSection component of refactored TaskDetails subcomponents
    
    * test: Add unit tests for TaskDependencies component of refactored TaskDetails subcomponents
    
    * chore: remove react memo from every component as it was unnecessary
    
    * chore: remove react memo from every component as it was unnecessary
    
    * refactor: TaskDates component to conditionally render Details based on extension request status
    
    * refactor: switch to named exports for all of the sub-components
    
    * chore: remove any from TaskDetails component and replace them with appropiates type
    
    * chore
    
    * Delete src/components/taskDetails/TaskProgress.tsx
    
    * Delete src/components/taskDetails/TaskParticipants.tsx
    
    * Delete src/components/taskDetails/TaskHeader.tsx
    
    * Delete src/components/taskDetails/TaskDetailsSection.tsx
    
    * Delete src/components/taskDetails/TaskDescription.tsx
    
    * Delete src/components/taskDetails/TaskDependencies.tsx
    
    * Delete src/components/taskDetails/TaskDates.tsx
    
    * chore: removed default export from every  sub-component as we are already using named export
    
    * chore: removed default export from every  sub-component as we are already using named export
    
    * refactor: refactor test codes to use named export instead of default exports
    
    * refactor(TaskDetails): remove unnecessary TaskProgress and TaskDependencies components and directly use underlying components
    
    * chore: remove test code of taskdependency and taskprogress as i have already used them in underlying taskdetails component
    
    * chore: remove test code of taskdependency and taskprogress as i have already used them in underlying taskdetails component
    
    * refactor: refactor code to simplyfy code reading used is else instead of ternary operator
    
    * chore: remove extra Taskcontainer wrap that was impacting styling of update progress
    
    ---------
    
    Co-authored-by: Ashif Khan <54736284+ashifkhn@users.noreply.github.com>
    Co-authored-by: Amit Prakash <34869115+iamitprakash@users.noreply.github.com>
    3 people authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    933e06d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d68aa66 View commit details
    Browse the repository at this point in the history
  5. Dev to Main Sync (#1233) (#1248)

    * fix: assign text box alignment it would be be appearing where the name is
    
    * feat: Update TaskDetails component and fix test for assignee input
    
    - Updated TaskDetails component to include assignee input with a data-testid of 'assignee-input'.
    - Modified the test for rendering the assignee dropdown to correctly identify the assignee input field using the updated test ID.
    - Ensured the test checks for the presence of the assignee input field in edit mode.
    
    * refactor: make the superuser to false on test files
    
    * refactor: Reintroduce getExtensionRequestLink function to TaskDetails component
    
    - Added back the getExtensionRequestLink function to handle the extension request URL generation.
    - Updated the assignee handling in the render method to include suggestions for editing.
    - Maintained the isEditing and isUserAuthorized checks for showing the assignee input field.
    - Ensured the task extension request link is correctly generated and displayed in the Dates section.
    
    * fix: Resolve duplicate input field and suggestion box issues in TaskDetails
    
    - Fixed issue with duplicate input fields appearing in the Assignee section.
    - Ensured the suggestion box appears correctly below the Assignee input field.
    - Applied consistent styling to the Assignee input field and suggestion box.
    - Linked the label to the input field using the  attribute.
    - Refactored the Assignee input and suggestion box to use the Suggestions component properly.
    
    * fix: classname to be more generic
    
    * refactor: test cases to use those old values
    
    * fix: Ensure consistent width for suggestion box and refactor styles
    
    - Updated suggestion box styles to maintain a consistent width relative to the input field
    - Ensured suggestion box width is set to 100% of its parent container
    - Adjusted styles for better visual consistency
    
    * Fix: Assignee text box alignment (#1225)
    
    * fix: assign text box alignment it would be be appearing where the name is
    
    * feat: Update TaskDetails component and fix test for assignee input
    
    - Updated TaskDetails component to include assignee input with a data-testid of 'assignee-input'.
    - Modified the test for rendering the assignee dropdown to correctly identify the assignee input field using the updated test ID.
    - Ensured the test checks for the presence of the assignee input field in edit mode.
    
    * refactor: make the superuser to false on test files
    
    * refactor: Reintroduce getExtensionRequestLink function to TaskDetails component
    
    - Added back the getExtensionRequestLink function to handle the extension request URL generation.
    - Updated the assignee handling in the render method to include suggestions for editing.
    - Maintained the isEditing and isUserAuthorized checks for showing the assignee input field.
    - Ensured the task extension request link is correctly generated and displayed in the Dates section.
    
    * fix: Resolve duplicate input field and suggestion box issues in TaskDetails
    
    - Fixed issue with duplicate input fields appearing in the Assignee section.
    - Ensured the suggestion box appears correctly below the Assignee input field.
    - Applied consistent styling to the Assignee input field and suggestion box.
    - Linked the label to the input field using the  attribute.
    - Refactored the Assignee input and suggestion box to use the Suggestions component properly.
    
    * fix: classname to be more generic
    
    * refactor: test cases to use those old values
    
    * fix: Ensure consistent width for suggestion box and refactor styles
    
    - Updated suggestion box styles to maintain a consistent width relative to the input field
    - Ensured suggestion box width is set to 100% of its parent container
    - Adjusted styles for better visual consistency
    
    * Corrected loading issue and extra space in standup submit (#1230)
    
    
    
    * fix: prevent Status field from being displayed twice in TaskDetails component
    
    Refactored TaskDetails component to conditionally render either the TaskDropDown for editing or the Details component for viewing the status, ensuring the Status field is only displayed once depending on the editing state.
    
    * fix: prevent Status field from being displayed twice in TaskDetails component
    
    Refactored TaskDetails component to conditionally render either the TaskDropDown for editing or the Details component for viewing the status, ensuring the Status field is only displayed once depending on the editing state.
    
    * Fix: Assignee text box alignment (#1225) (#1228) (#1234)
    
    * Refactor else condition (#1240)
    
    * Corrected loading issue and extra space in standup submit
    
    * Fixed early return
    
    ---------
    
    
    
    ---------
    
    Co-authored-by: Amit Prakash <34869115+iamitprakash@users.noreply.github.com>
    Co-authored-by: Shubham Sharma <68867418+skv93-coder@users.noreply.github.com>
    Co-authored-by: Shubham Sharma <shbh541@gmail.com>
    4 people authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c0e1a94 View commit details
    Browse the repository at this point in the history
  6. Revert "Dev to Main Sync (#1233) (#1248)" (#1249)

    This reverts commit c0e1a94.
    iamitprakash authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    615b997 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b2db7cc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a110b65 View commit details
    Browse the repository at this point in the history