Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving back Done status under dev flag #1254

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Conversation

skv93-coder
Copy link
Contributor

@skv93-coder skv93-coder commented Sep 9, 2024

Date: 9 Sep 2024

Developer Name: @skv93-coder


Issue Ticket Number

Description

This PR applies dev flag for DONE status

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

image

image

image

image

Test Coverage

Screenshot 1

image

image

image

image

Additional Notes

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 8:04pm

@skv93-coder skv93-coder marked this pull request as ready for review September 9, 2024 16:24
@Ayushsanjdev
Copy link
Contributor

wow, that decreased a lot of lines @skv93-coder LGTM!

Copy link
Contributor

@Ayushsanjdev Ayushsanjdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please re-name PR title

@skv93-coder skv93-coder changed the title Fix/revert/done moving back Done status under dev flag Sep 19, 2024
@skv93-coder
Copy link
Contributor Author

please re-name PR title

done

@skv93-coder skv93-coder changed the title moving back Done status under dev flag Moving back Done status under dev flag Sep 19, 2024
@iamitprakash iamitprakash merged commit a8562cc into develop Sep 20, 2024
3 checks passed
@iamitprakash iamitprakash deleted the fix/revert/done branch September 20, 2024 18:00
@skv93-coder skv93-coder mentioned this pull request Sep 23, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DONE status got released in task details page
4 participants