Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix alert message on issues page #1256

Merged

Conversation

Mir-SA
Copy link
Contributor

@Mir-SA Mir-SA commented Sep 10, 2024

Date: 10/09/24

Developer Name: Sameer Supe


Issue Ticket Number

Description

Fixes alert box which pops behind modal overlay. Conflict comes in from similar z-index value(9999) of modal overlay and react-toastify component.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1
issues-screenshot.mp4

Test Coverage

Screenshot 1

status-tests

Additional Notes

Copy link

vercel bot commented Sep 10, 2024

@Mir-SA is attempting to deploy a commit to the RDS-Team Team on Vercel.

A member of the Team first needs to authorize it.

@iamitprakash iamitprakash merged commit b51e8f7 into Real-Dev-Squad:develop Sep 11, 2024
1 of 2 checks passed
@Mir-SA Mir-SA mentioned this pull request Sep 12, 2024
10 tasks
@@ -10,7 +10,7 @@
}
}
.modalOverlay {
z-index: 9999;
z-index: 9998;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why is soo large Z index needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please create a seperate issues to fix the z index values, having random large values will create lots of issues in future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the Alert messaging
3 participants