Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to Main Sync #1261

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Dev to Main Sync #1261

merged 2 commits into from
Sep 16, 2024

Conversation

iAmAshuSahoo
Copy link
Contributor

@iAmAshuSahoo iAmAshuSahoo commented Sep 16, 2024

Date: 17 September 2024

Developer Name: @iAmAshuSahoo


Issue Ticket Number

PR's Going in These Sync

Description

  • @iAmAshuSahoo changes enum values to upper case snake case for consistency.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Below changes were pushed to develop and were verified on staging

image

* changed the date details to camel case

* test are failing

* changed to decided variable types

* updated tests

* updated mocking of system time

* date is mocked

* remove unnecessary test

* test done

* change setting

* removed hardcoding

---------

Co-authored-by: Amit Prakash <34869115+iamitprakash@users.noreply.github.com>
Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 7:23pm

@iAmAshuSahoo iAmAshuSahoo self-assigned this Sep 16, 2024
@iAmAshuSahoo iAmAshuSahoo changed the title Dev2Main Sync - Changing enum values to upper case snake case for consistency (#1253) Dev to Main Sync - Changing enum values to upper case snake case for consistency (#1253) Sep 16, 2024
@Achintya-Chatterjee Achintya-Chatterjee changed the title Dev to Main Sync - Changing enum values to upper case snake case for consistency (#1253) Dev to Main Sync Sep 16, 2024
@iamitprakash iamitprakash merged commit a0868b0 into main Sep 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants