Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type when merging optional properties of a record #452

Merged
merged 1 commit into from
May 19, 2024
Merged

fix: type when merging optional properties of a record #452

merged 1 commit into from
May 19, 2024

Conversation

RebeccaStevens
Copy link
Owner

@RebeccaStevens RebeccaStevens commented May 12, 2024 •
edited
Loading

fix #451

This was referenced May 12, 2024
Merged
Merged
Merged
Merged
Merged
@RebeccaStevens Graphite App
Copy link
Owner Author

RebeccaStevens commented May 12, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RebeccaStevens and the rest of your teammates on Graphite Graphite

@RebeccaStevens RebeccaStevens marked this pull request as ready for review May 12, 2024 10:44
@RebeccaStevens RebeccaStevens marked this pull request as draft May 12, 2024 10:44
@RebeccaStevens RebeccaStevens force-pushed the 05-12-fix_discriminated_unions_can_cause_incorrect_return_types branch from fd98a18 to 4ec666d Compare May 14, 2024 06:57
@RebeccaStevens RebeccaStevens changed the base branch from 05-10-feat_remove_deprecated_type_deepmergeleafhkt to 05-14-perf_remove_blacklistedrecordprops May 14, 2024 06:57
@RebeccaStevens RebeccaStevens mentioned this pull request May 14, 2024
Merged
@RebeccaStevens RebeccaStevens marked this pull request as ready for review May 14, 2024 06:57
@RebeccaStevens RebeccaStevens marked this pull request as draft May 14, 2024 06:58
@RebeccaStevens RebeccaStevens force-pushed the 05-14-perf_remove_blacklistedrecordprops branch from da465e4 to 70d1c9b Compare May 14, 2024 07:58
@RebeccaStevens RebeccaStevens force-pushed the 05-12-fix_discriminated_unions_can_cause_incorrect_return_types branch 2 times, most recently from 31136ea to 35c0708 Compare May 18, 2024 13:09
@RebeccaStevens RebeccaStevens changed the title fix: discriminated unions can cause incorrect return types fix: merging of optional properties of a record May 19, 2024
@RebeccaStevens RebeccaStevens force-pushed the 05-14-perf_remove_blacklistedrecordprops branch from 70d1c9b to c8fa7ca Compare May 19, 2024 02:38
@RebeccaStevens RebeccaStevens force-pushed the 05-12-fix_discriminated_unions_can_cause_incorrect_return_types branch from 35c0708 to a2b468a Compare May 19, 2024 02:38
@RebeccaStevens RebeccaStevens marked this pull request as ready for review May 19, 2024 02:38
@RebeccaStevens RebeccaStevens changed the title fix: merging of optional properties of a record fix: type when merging optional properties of a record May 19, 2024
@RebeccaStevens RebeccaStevens force-pushed the 05-12-fix_discriminated_unions_can_cause_incorrect_return_types branch from a2b468a to 0de2d83 Compare May 19, 2024 02:44
@RebeccaStevens RebeccaStevens force-pushed the 05-14-perf_remove_blacklistedrecordprops branch from c8fa7ca to f308ca1 Compare May 19, 2024 03:11
@RebeccaStevens RebeccaStevens force-pushed the 05-12-fix_discriminated_unions_can_cause_incorrect_return_types branch from 0de2d83 to c8d5d0a Compare May 19, 2024 03:11
@RebeccaStevens RebeccaStevens force-pushed the 05-14-perf_remove_blacklistedrecordprops branch from f308ca1 to 32d259c Compare May 19, 2024 03:19
@RebeccaStevens RebeccaStevens force-pushed the 05-12-fix_discriminated_unions_can_cause_incorrect_return_types branch from c8d5d0a to 0b7aa02 Compare May 19, 2024 03:19
@RebeccaStevens RebeccaStevens force-pushed the 05-14-perf_remove_blacklistedrecordprops branch from 32d259c to 0dd1c0d Compare May 19, 2024 03:54
@RebeccaStevens RebeccaStevens force-pushed the 05-12-fix_discriminated_unions_can_cause_incorrect_return_types branch from 0b7aa02 to 64f59c8 Compare May 19, 2024 03:54
@RebeccaStevens RebeccaStevens mentioned this pull request May 19, 2024
Merged
@RebeccaStevens RebeccaStevens force-pushed the 05-12-fix_discriminated_unions_can_cause_incorrect_return_types branch from 64f59c8 to fdffcf7 Compare May 19, 2024 04:05
@RebeccaStevens RebeccaStevens force-pushed the 05-12-fix_discriminated_unions_can_cause_incorrect_return_types branch from fdffcf7 to 726fb3e Compare May 19, 2024 04:15
@RebeccaStevens RebeccaStevens added the Status: Released on Next It's now live on the next branch. label May 19, 2024
@RebeccaStevens RebeccaStevens force-pushed the 05-14-perf_remove_blacklistedrecordprops branch from 0dd1c0d to 6b10899 Compare May 19, 2024 10:45
@RebeccaStevens RebeccaStevens force-pushed the 05-12-fix_discriminated_unions_can_cause_incorrect_return_types branch from 726fb3e to 02fcd3b Compare May 19, 2024 10:45
@RebeccaStevens Graphite App
Copy link
Owner Author

RebeccaStevens commented May 19, 2024 •
edited
Loading

Merge activity

@RebeccaStevens RebeccaStevens force-pushed the 05-14-perf_remove_blacklistedrecordprops branch from 6b10899 to 33c7901 Compare May 19, 2024 11:06
Base automatically changed from 05-14-perf_remove_blacklistedrecordprops to main May 19, 2024 11:08
@RebeccaStevens RebeccaStevens force-pushed the 05-12-fix_discriminated_unions_can_cause_incorrect_return_types branch from 02fcd3b to 297b3e6 Compare May 19, 2024 11:08
@RebeccaStevens RebeccaStevens merged commit fa9ace2 into main May 19, 2024
11 checks passed
@RebeccaStevens RebeccaStevens deleted the 05-12-fix_discriminated_unions_can_cause_incorrect_return_types branch May 19, 2024 11:10
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the Status: Released It's now live. label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Released on Next It's now live on the next branch. Status: Released It's now live.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect return type when mixing optional and non-optional keys
1 participant
@RebeccaStevens