Update handling of the MOTD file #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-horky
force-pushed
the
motd-fix
branch
2 times, most recently
from
0227026
to
f2a3d84
Compare
|
I noticed the motd symlink code was broken resulting in errors when building insights-client from scratch. I'm assuming this includes fixes for that issue. I'll have a look next week if no one else has already reviewed this by then 👍 |
I hope I've hit the same problem as you did during build. The issue is only upstream, I didn't report any bug for it since it hasn't been built yet. |
1/ Improve logging; be more explicit about what is being done 2/ Remove the file instead of symlinking to /dev/null 3/ Handle situations in which the motd symlink is broken (Updates 0ee6971)
ptoscano
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/ Improve logging; be more explicit about what is being done
2/ Remove the file instead of symlinking to /dev/null
3/ Handle situations in which the motd symlink is broken
(Updates 0ee6971)