Check the sources with flake8 #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pino Toscano <ptoscano@redhat.com>
Signed-off-by: Pino Toscano <ptoscano@redhat.com>
Fix & improve a bit the configuration for flake8, so it can be run without issues: - drop all the old ignores, no more needed (all the issues where fixed) - drop the excludes for paths that are either do not exist anymore, or that it is not a problem to scan (e.g. "docs") - add the explicit filename patterns so "*.py.in" files are scanned too; adding ".py" is needed since "filename" replaces the default paths - set the same line length as used by black - add a couple of known ignores related to the style formatted by black - ignore longer lines in a couple of files; they are there already, and fixing them can be done gradually - exclude also the default meson build directory Signed-off-by: Pino Toscano <ptoscano@redhat.com>
In addition to the format with black, check the sources also using flake8. The job will install flake8 as available in the latest stable Fedora version. Use a marketplace action to annotate the files with the result of the flake8 run. Signed-off-by: Pino Toscano <ptoscano@redhat.com>
Signed-off-by: Pino Toscano <ptoscano@redhat.com>
m-horky
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format()(fixes F522)import(fixes F401).flake8file according to the current sourcesflake8in the existingstylishGHA workflowSee the messages of the commits for longer descriptions.