Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the sources with flake8 #196

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Check the sources with flake8 #196

merged 5 commits into from
Mar 13, 2024

Commits on Mar 13, 2024

  1. chore: drop unused arguments to string.format() 

    Signed-off-by: Pino Toscano <ptoscano@redhat.com>
    @ptoscano
    ptoscano committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    756d96f View commit details
    Browse the repository at this point in the history

  2. chore: drop unused import 

    Signed-off-by: Pino Toscano <ptoscano@redhat.com>
    @ptoscano
    ptoscano committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    21ab741 View commit details
    Browse the repository at this point in the history

  3. chore: fix/improve flake8 configuration 

    Fix & improve a bit the configuration for flake8, so it can be run
without issues:
- drop all the old ignores, no more needed (all the issues where fixed)
- drop the excludes for paths that are either do not exist anymore, or
  that it is not a problem to scan (e.g. "docs")
- add the explicit filename patterns so "*.py.in" files are scanned too;
  adding ".py" is needed since "filename" replaces the default paths
- set the same line length as used by black
- add a couple of known ignores related to the style formatted by black
- ignore longer lines in a couple of files; they are there already, and
  fixing them can be done gradually
- exclude also the default meson build directory

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
    @ptoscano
    ptoscano committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c18bd92 View commit details
    Browse the repository at this point in the history

  4. ci: extend stylish workflow with flake8 check 

    In addition to the format with black, check the sources also using
flake8. The job will install flake8 as available in the latest stable
Fedora version.

Use a marketplace action to annotate the files with the result of the
flake8 run.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
    @ptoscano
    ptoscano committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    7624555 View commit details
    Browse the repository at this point in the history

  5. chore: add flake8 to development requirements 

    Signed-off-by: Pino Toscano <ptoscano@redhat.com>
    @ptoscano
    ptoscano committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    a3fef3b View commit details
    Browse the repository at this point in the history