Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable redhat-access-insights only in RHEL < 10 #254

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

ptoscano
Copy link
Contributor

There is no need for it anymore, so keep it only for existing enterprise
distributions.

A new redhat_access_insights meson option (which is false by default) is used to enable that deprecated executable.

Card ID: CCT-419

Wrap each argument in its own line, adding a %nil marker at the end.
There are no behaviour changes; this simplifies adding conditional
options later on.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
Add a meson option to control whether the deprecated
'redhat-access-insights' executable is created.

The default is false to not build a deprecated bit by default;
to preserve the existing behaviour, the packaging unconditionally
enables it.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
There is no need for it anymore, so keep it only for existing enterprise
distributions.

Card ID: CCT-419

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
Copy link
Contributor

@subpop subpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@subpop
Copy link
Contributor

subpop commented Jun 12, 2024

I verified that the RHEL 9 RPM does include /usr/bin/redhat-access-insights, while the Fedora 10 does not.

@subpop subpop merged commit fa7792a into RedHatInsights:master Jun 12, 2024
21 checks passed
@ptoscano ptoscano deleted the meson-access-insights branch June 12, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants