fix: use system temporary directory when running as non-root #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The temporary directory chosen to work properly with SELinux is /var/lib/insights, which can be accessed only by root. insights-client is basically not usable as non-root, and it will fail with "Insights client must be run as root.". The only exception here is "insights-client --version", which is run only in the client without loading the core; the exception is that the client will still verify the available eggs using GPG by default. Hence, use the default temporary directory when running as non-root: this way the available eggs can be validated, and the client will either - print the version and exit - keep exiting saying root is required Followup of commit dd6293d.
m-horky
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The temporary directory chosen to work properly with SELinux is
/var/lib/insights, which can be accessed only by root.insights-clientis basically not usable as non-root, and it will fail withInsights client must be run as root.. The only exception here isinsights-client --version, which is run only in the client without loading the core; the exception is that the client will still verify the available eggs using GPG by default.Hence, use the default temporary directory when running as non-root: this way the available
eggs can be validated, and the client will either
Followup of commit dd6293d.