RC: Fix setup of jvm.args for 1.0.1 messages (#267)

RedHatInsights · Oct 7, 2024 · 4dfcc94 · 4dfcc94
1 parent 0266b14
commit 4dfcc94
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/api/src/main/java/com/redhat/insights/reports/AbstractTopLevelReportBase.java b/api/src/main/java/com/redhat/insights/reports/AbstractTopLevelReportBase.java
@@ -179,7 +179,7 @@ public void generateReport(Filtering masking) {
 
     RuntimeMXBean runtimeMXBean = ManagementFactory.getRuntimeMXBean();
     List<String> inputArguments = fixInputArguments(runtimeMXBean.getInputArguments());
-    options.put("jvm.args", inputArguments);
+    options.put("jvm.args", String.join(" ", inputArguments));
 
     MemoryMXBean memoryMXBean = ManagementFactory.getMemoryMXBean();
     MemoryUsage heapMemoryUsage = memoryMXBean.getHeapMemoryUsage();

diff --git a/api/src/main/java/com/redhat/insights/reports/Utils.java b/api/src/main/java/com/redhat/insights/reports/Utils.java
@@ -1,22 +1,15 @@
 /* Copyright (C) Red Hat 2023-2024 */
 package com.redhat.insights.reports;
 
-import static java.util.Collections.emptyMap;
-
 import java.util.ArrayList;
-import java.util.List;
 import java.util.Map;
 
 public final class Utils {
   private Utils() {}
 
   @SuppressWarnings("unchecked")
   public static Map<String, Object> defaultMasking(final Map<String, Object> inArgs) {
-    List<String> jvmArgs = new ArrayList<>();
-    List<String> args = (List<String>) (inArgs.getOrDefault("jvm.args", emptyMap()));
-    for (String arg : args) {
-      jvmArgs.add(sanitizeJavaParameters(arg));
-    }
+    String jvmArgs = sanitizeJavaParameters((String) (inArgs.getOrDefault("jvm.args", "")));
     inArgs.put("jvm.args", jvmArgs);
     String command = (String) inArgs.getOrDefault("java.command", "");
     inArgs.put("java.command", sanitizeJavaParameters(command));

diff --git a/api/src/test/java/com/redhat/insights/TestTopLevelReport.java b/api/src/test/java/com/redhat/insights/TestTopLevelReport.java
@@ -326,7 +326,7 @@ public void testReportSanitization() throws IOException {
       Map<?, ?> basicReport = (Map<?, ?>) parseReport(report).get("basic");
 
       assertEquals(
-          sanitizedJvmArgs,
+          String.join(" ", sanitizedJvmArgs.toArray(new String[0])),
           basicReport.get("jvm.args"),
           "The \"jvm.args\" property in the basic report should be properly sanitized.");
       assertEquals(