Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CherryPicked: [v4.13] CherryPicked: [v4.14] Use poetry as build backend #1290

Merged
merged 1 commit into from
Jul 27, 2023
Merged

CherryPicked: [v4.13] CherryPicked: [v4.14] Use poetry as build backend #1290

merged 1 commit into from
Jul 27, 2023

Conversation

redhat-qe-bot
Copy link
Contributor

cherry-pick #1286 into v4.13

requested-by redhat-qe-bot

@redhat-qe-bot @myakove
Use poetry as build backend (#1284) (#1286)
9c274e3 
* Use poetry as build backend

* Use poetry as build backend

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
@redhat-qe-bot
Copy link
Contributor Author

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Cherry-pick will be started when PR is merged
  • To re-run tox comment /retest tox in the PR.
  • To re-run build-container command /retest build-container in the PR.
  • To re-run python-module-install command /retest python-module-install in the PR.
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported labels
  • hold
  • verified
  • wip
  • lgtm
  • approve

@redhat-qe-bot redhat-qe-bot self-assigned this Jul 27, 2023
@redhat-qe-bot redhat-qe-bot mentioned this pull request Jul 27, 2023
Closed
@myakove
Copy link
Collaborator

myakove commented Jul 27, 2023

/cherry-pick v4.12

@redhat-qe-bot
Copy link
Contributor Author

Cherry-pick requested for PR: "
"CherryPicked: [v4.13] CherryPicked: [v4.14] Use poetry as build backend"
"Adding label cherry-pick-v4.12 for automatic cheery-pick once the PR is merged"

@myakove
Copy link
Collaborator

myakove commented Jul 27, 2023

/verified

@myakove
Copy link
Collaborator

myakove commented Jul 27, 2023

/lgtm

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@myakove myakove merged commit 18e4d13 into v4.13 Jul 27, 2023
7 checks passed
@myakove myakove deleted the CherryPicked-CherryPicked-use-poetry-for-build-CLxqi-DPUwU branch July 27, 2023 11:48
@redhat-qe-bot
Copy link
Contributor Author

Manual cherry-pick is needed
Cherry pick failed for 18e4d13 to v4.12:
To cherry-pick run:

git fetch --all
git checkout v4.12
git checkout -b CherryPicked-CherryPicked-use-poetry-for-build-CLxqi-DPUwU-v4.12
git cherry-pick 18e4d13df8ce7b5496fe79872c74f1d8894f2470
git push origin CherryPicked-CherryPicked-use-poetry-for-build-CLxqi-DPUwU-v4.12

myakove added a commit that referenced this pull request Jul 27, 2023
@redhat-qe-bot @myakove
Use poetry as build backend (#1284) (#1286) (#1290)
9560faa 
* Use poetry as build backend

* Use poetry as build backend

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
myakove added a commit that referenced this pull request Jul 27, 2023
@redhat-qe-bot @myakove
Use poetry as build backend (#1284) (#1286) (#1290)
30fdfad 
* Use poetry as build backend

* Use poetry as build backend

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
rnetser pushed a commit that referenced this pull request Jul 27, 2023
@myakove @redhat-qe-bot
Use poetry as build backend (#1284) (#1286) (#1290) (#1294)
88faa6e 
* Use poetry as build backend

* Use poetry as build backend

Co-authored-by: redhat-qe-bot <108792105+redhat-qe-bot@users.noreply.github.com>
@redhat-qe-bot redhat-qe-bot mentioned this pull request Jul 27, 2023
Closed
myakove added a commit that referenced this pull request Jul 27, 2023
@myakove @redhat-qe-bot
Use poetry as build backend (#1284) (#1286) (#1290) (#1294)
84be6f5 
* Use poetry as build backend

* Use poetry as build backend

Co-authored-by: redhat-qe-bot <108792105+redhat-qe-bot@users.noreply.github.com>
myakove added a commit that referenced this pull request Jul 27, 2023
@myakove @redhat-qe-bot
Use poetry as build backend (#1284) (#1286) (#1290) (#1294) (#1296)
7cc98d3 
* Use poetry as build backend

* Use poetry as build backend

Co-authored-by: redhat-qe-bot <108792105+redhat-qe-bot@users.noreply.github.com>
redhat-qe-bot added a commit that referenced this pull request Jul 27, 2023
@myakove @redhat-qe-bot
Use poetry as build backend (#1284) (#1286) (#1290) (#1294) (#1296)
a7d8f5f 
* Use poetry as build backend

* Use poetry as build backend

Co-authored-by: redhat-qe-bot <108792105+redhat-qe-bot@users.noreply.github.com>
@redhat-qe-bot redhat-qe-bot mentioned this pull request Jul 27, 2023
Merged
myakove added a commit that referenced this pull request Jul 27, 2023
@redhat-qe-bot @myakove
Use poetry as build backend (#1284) (#1286) (#1290) (#1294) (#1296) (#…
9ceb620 
…1298)

* Use poetry as build backend

* Use poetry as build backend

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
@redhat-qe-bot redhat-qe-bot mentioned this pull request Jul 27, 2023
Closed
redhat-qe-bot added a commit that referenced this pull request Jul 27, 2023
@redhat-qe-bot @myakove
Use poetry as build backend (#1284) (#1286) (#1290) (#1294) (#1296) (#…
e5a8002 
…1298)

* Use poetry as build backend

* Use poetry as build backend

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
@redhat-qe-bot redhat-qe-bot mentioned this pull request Jul 27, 2023
Merged
myakove added a commit that referenced this pull request Jul 27, 2023
@redhat-qe-bot @myakove
Use poetry as build backend (#1284) (#1286) (#1290) (#1294) (#1296) (#…
f79a778 
…1298) (#1300)

* Use poetry as build backend

* Use poetry as build backend

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
redhat-qe-bot added a commit that referenced this pull request Jul 27, 2023
@redhat-qe-bot @myakove
Use poetry as build backend (#1284) (#1286) (#1290) (#1294) (#1296) (#…
053a3bf 
…1298) (#1300)

* Use poetry as build backend

* Use poetry as build backend

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
@redhat-qe-bot redhat-qe-bot mentioned this pull request Jul 27, 2023
Merged
myakove added a commit that referenced this pull request Jul 27, 2023
@redhat-qe-bot @myakove
Use poetry as build backend (#1284) (#1286) (#1290) (#1294) (#1296) (#…
14101a0 
…1298) (#1300) (#1302)

* Use poetry as build backend

* Use poetry as build backend

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myakove myakove Awaiting requested review from myakove

@rnetser rnetser Awaiting requested review from rnetser

@omrirh omrirh Awaiting requested review from omrirh

@oharan2 oharan2 Awaiting requested review from oharan2

Assignees

@redhat-qe-bot redhat-qe-bot

Labels
ApprovedBy-myakove branch-v4.13 can-be-merged cherry-pick-v4.12 size/XXL verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redhat-qe-bot @myakove