-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: resolve refs in config #1345
Conversation
🦋 Changeset detectedLatest commit: 0231d42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
a893d88
to
d7fc2eb
Compare
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success653 tests passing in 94 suites. Report generated by 🧪jest coverage report action from 0231d42 |
35e6eba
to
3eafa4b
Compare
…s and added basic tests
0fa4b53
to
7983be2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Heather Cloward <heathercloward@gmail.com>
The link checker started failing for some strange reason (Dockerhub responds with 429 status despite being available from the browser), even on the |
What/Why/How?
This allows using $ref in config files like this:
push
command with $ref's in config file, user should explicitly upload all referenced files in the config using--files
option.Look into Error resolving $ref pointer redoc#740 (comment)(is not related; better to be handled in a separate MR)Also fixed a couple of issues with resolving refs and formatting the output.
Reference
Resolves #1219
Testing
Screenshots (optional)
Check yourself
Security