Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused lodash.isequal dependency #1828

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

alexparish
Copy link
Contributor

@alexparish alexparish commented Dec 17, 2024

What/Why/How?

Remove unused lodash.isequal dependency.

I've also removed the package-lock.json file at packages/core/package-lock.json as I believe it to be redundant.

Reference

Fixes #1818

Testing

I have run the jest tests locally and they pass.

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@alexparish alexparish requested a review from a team as a code owner December 17, 2024 20:55
Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: 53ad412

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/openapi-core Patch
@redocly/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexparish alexparish force-pushed the remove-unused-lodash-dependency branch 2 times, most recently from 3251e18 to 9228bf9 Compare December 17, 2024 20:56
@alexparish alexparish requested a review from a team as a code owner December 17, 2024 20:56
Copy link
Contributor

@tatomyr tatomyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@tatomyr tatomyr merged commit 901a6d6 into Redocly:main Dec 18, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused lodash.isequal dependency
3 participants