Implement basic C# translation parser plugin #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is neat, we're currently not working in master at the moment. We'll have to come back and look at this after we got all the rebranding stuff done and into master. |
|
Is it possible to write this feature in C#? Just like the C# export feature, if write this feature in C#, should have an advantage in parsing the C# source code. |
|
I would also like to see this type of feature sent upstream to Godot, though yeah probably a better plan if this could be done from C# for source code parsing reasons. |
|
Since we've re-assessed our position on sending things upstream by default recently, we can take a look at this closely soon |
|
Changes to this PR were already requested, the author has not come back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a basic C# translation parser plugin. It extracts
Tr,TrN,AtrandAtrNcalls from C# scripts and generates entries for the POT file generator. The implementation is very basic compared to the GDScript translation parser because we can't properly parse C# source code for obvious reasons.I have no prior C++ experience at all. I only implemented this because I needed it for my project.