Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the Web-Editor build and styles #752

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MarekZeman91
Copy link

@MarekZeman91 MarekZeman91 commented Oct 17, 2024

BEFORE

Old Intro Old Editor

AFTER

New Intro New Editor

Main changes

  • colors and naming changes to reflect the rebranding
  • JavaScript in editor.html optimized
  • CSS from editor.html moved to styles.css
  • tabs are aligned to the right and have active state
  • fixed JavaScript errors for missing variables
  • removed JavaScript infinite focus loop

IMPORTANT BUILD INFO

The web build works with UP TO emsdk 3.1.67.

Here is my Makefile:

build:
	../emsdk/emsdk install 3.1.67 && ../emsdk/emsdk activate 3.1.67 && source ../emsdk/emsdk_env.sh && scons platform=web target=editor

serve:
	python3 platform/web/serve.py

@SkogiB SkogiB added enhancement rebranding issues and pr's related to engine rebranding needs testing performance labels Oct 17, 2024
@SkogiB
Copy link
Contributor

SkogiB commented Oct 17, 2024

Awesome. I dunno the demand for it, but it looks like a good idea. Could you add a comparison image of before and after so people can quickly preview your changes? We can also cherry pick this to 4.3 later

Also, install pre-commit. We're trying to get everyone up to speed on that, it should help you pass the static checker easier.

@MarekZeman91
Copy link
Author

MarekZeman91 commented Oct 18, 2024

Awesome. I dunno the demand for it, but it looks like a good idea. Could you add a comparison image of before and after so people can quickly preview your changes? We can also cherry pick this to 4.3 later

Also, install pre-commit. We're trying to get everyone up to speed on that, it should help you pass the static checker easier.

I didn't manage to get the pre-commit working. I use Lint and other tools daily but it didn't work well on this project. I fixed it from the info I got from CLI. Hope it is fine now.

@SkogiB
Copy link
Contributor

SkogiB commented Oct 24, 2024

Awesome. I dunno the demand for it, but it looks like a good idea. Could you add a comparison image of before and after so people can quickly preview your changes? We can also cherry pick this to 4.3 later
Also, install pre-commit. We're trying to get everyone up to speed on that, it should help you pass the static checker easier.

I didn't manage to get the pre-commit working. I use Lint and other tools daily but it didn't work well on this project. I fixed it from the info I got from CLI. Hope it is fine now.

Sorry for the delays man, running the workflow now to check the fixes, once we know stuff is good we just need the commits squashed so it doesn't clutter the commit history and we're good to go on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs testing performance rebranding issues and pr's related to engine rebranding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants