-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mod to 1.20.4 #363
Open
RUGMJ
wants to merge
56
commits into
main
Choose a base branch
from
rewrite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update mod to 1.20.4 #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….gradle, and fabric.mod.json were changed to account for any versioning. Then the command "gradlew migrateMappings --mappings "1.20.4+build.3" was run to fix mixin errors. After that, the Gradle was updated from 8.1.1 to 8.5 due to a need by 1.20.4 Fabric. Finally, the migrateMappings command made a new src folder and copied everything over with the fixed mixins. As such I've named the old src file "oldSrc" until we decide to delete it.
Deleted oldSrc
More 1.20 Codebase
…ow denoted with Text.literal or Text.of)
Deleted random ununsed imports and fixed all the LiteralText errors
Fixed all the GUI errors
…nd adding the serializers as subclasses.
Serializer Changes to Arguments
… them to the game
Ported macro GUI
MMT007
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides The Minor Visual Bug When Using The "Air Place Feature", This Seems To Be A Functional Release/Release-Candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs testing and code reviewing before we merge, i suggest we release a beta build of the mod for mass testing via the discord sever